Skip to main content

Search and Top Navigation

#7792 closed enhancement (notabug)

Opened October 13, 2011 07:26PM UTC

Closed October 13, 2011 08:21PM UTC

Widget: Check if option changed before calling _setOption

Reported by: jzaefferer Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.widget Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:

If an option value didn't actually change, a lot of code probably shouldn't run at all. Should be possible to implement that within option or _setOptions.

Attachments (0)
Change History (2)

Changed October 13, 2011 08:11PM UTC by rdworth comment:1

I'd rather see this done as-needed in specific widgets, otherwise a widget is incapable of knowing about a setOption that is setting the value to the current value. That could be done to force a side effect or a type of refresh (maybe a full refresh is not available or would be more drastic). An example of this is setting the dialog position.

Changed October 13, 2011 08:21PM UTC by jzaefferer comment:2

resolution: → invalid
status: newclosed