Opened 11 years ago
Closed 11 years ago
#7810 closed bug (fixed)
Consistent naming convention for .data() keys
Reported by: | Scott González | Owned by: | Jörn Zaefferer |
---|---|---|---|
Priority: | blocker | Milestone: | 1.9.0 |
Component: | [meta] ui.dev | Version: | 1.8.16 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
There's a lot of variation in naming conventions for data stored on elements. We should formalize a naming convention and use it everywhere.
Change History (4)
comment:1 Changed 11 years ago by
Priority: | minor → blocker |
---|---|
Status: | new → open |
comment:2 Changed 11 years ago by
Owner: | set to joern.zaefferer |
---|---|
Status: | open → assigned |
comment:3 Changed 11 years ago by
https://github.com/jquery/jquery-ui/pull/607 addresses a good chunk of this.
Remaining: Widget, interactions and datepicker.
Widget currently sets data based on the widget's name. Changing that needs a BC layer.
Interactions rely a lot on other interactions, accessing them via data attributes. Haven't yet looked in detail if those are problematic.
Datepicker's usage is very similar to wiget. Looks like it just sets a datepicker property, nothing else.
comment:4 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
We'll ignore datepicker and interactions for now, as those are being rewritten. Everything else is addressed.
Started this in the data-naming branch.