Opened 8 years ago

Closed 7 years ago

#7810 closed bug (fixed)

Consistent naming convention for .data() keys

Reported by: Scott González Owned by: Jörn Zaefferer
Priority: blocker Milestone: 1.9.0
Component: [meta] ui.dev Version: 1.8.16
Keywords: Cc:
Blocked by: Blocking:

Description

There's a lot of variation in naming conventions for data stored on elements. We should formalize a naming convention and use it everywhere.

Change History (4)

comment:1 Changed 8 years ago by Scott González

Priority: minorblocker
Status: newopen

comment:2 Changed 7 years ago by Jörn Zaefferer

Owner: set to joern.zaefferer
Status: openassigned

Started this in the data-naming branch.

comment:3 Changed 7 years ago by Jörn Zaefferer

https://github.com/jquery/jquery-ui/pull/607 addresses a good chunk of this.

Remaining: Widget, interactions and datepicker.

Widget currently sets data based on the widget's name. Changing that needs a BC layer.

Interactions rely a lot on other interactions, accessing them via data attributes. Haven't yet looked in detail if those are problematic.

Datepicker's usage is very similar to wiget. Looks like it just sets a datepicker property, nothing else.

comment:4 Changed 7 years ago by Jörn Zaefferer

Resolution: fixed
Status: assignedclosed

We'll ignore datepicker and interactions for now, as those are being rewritten. Everything else is addressed.

Note: See TracTickets for help on using tickets.