Skip to main content

Search and Top Navigation

#7880 closed bug (fixed)

Opened November 14, 2011 01:17PM UTC

Closed January 31, 2012 05:50PM UTC

Last modified May 23, 2012 02:37PM UTC

Nested accordion icons

Reported by: j.hermsen Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.accordion Version: 1.8.16
Keywords: Cc:
Blocked by: Blocking:
Description

A little styling issue if you have nested accordions.

if you have a parent accordion with icons and the sub accordion does not have icons the header will inherit the padding of the parent accordion so more blank space on the left.

I'd suggest adding a css class for example "ui-accordion-noicons" incase icons==false.

Attachments (0)
Change History (3)

Changed November 14, 2011 05:23PM UTC by j.hermsen comment:1

_comment0: Not sure if I have the correct link here, but did a fork/fix and pull request. \ \ https://github.com/jquery/jquery-ui/pull/5251321293342477149
_comment1: Not sure if I have the correct link here, but did a fork/fix and pull request. \ \ https://github.com/jquery/jquery-ui/pull/525 \ \ Screenshot of the issue: \ [[Image(https://github.com/jhermsen/shared/blob/master/issues/accordionIssue.png?raw=true)]]1321293375077301

Not sure if I have the correct link here, but did a fork/fix and pull request.

https://github.com/jquery/jquery-ui/pull/525

Before/After screenshot of the issue:

[[Image(https://github.com/jhermsen/shared/blob/master/issues/accordionIssue.png?raw=true)]]

Changed January 31, 2012 05:50PM UTC by Scott González comment:2

resolution: → fixed
status: newclosed

Accordion: Moved the ui-accordion-icons class to the headers to properly style nested accordions with varying settings of icons and no icons. Fixes #7880 - Nested accordion.

Changeset: 5a55d68eca60b52cbd1ae1ab48a6c9b1f8817ef1

Changed May 23, 2012 02:37PM UTC by scottgonzalez comment:3

summary: Nested accordionNested accordion icons