Opened 11 years ago
Closed 10 years ago
#7945 closed feature (notabug)
ThemeRoller: Clean user data and/or prevent invalid inputs
Reported by: | welja | Owned by: | welja |
---|---|---|---|
Priority: | minor | Milestone: | 1.9.0 |
Component: | [meta] ui.themeroller | Version: | 1.8.16 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
When downloading this custom theme in the latest Firefox (link at bottom of ticket ) a background image gets a name with a percentage sign: ui-bg_highlight-soft_60%_ffa000_1x100.png which doesnot display in the browser.
Manual Fix: Remove % sign in image name and fix the corresponding css link ( line 69 )
Change History (5)
comment:1 Changed 11 years ago by
Owner: | changed from jquery-infrastructure to welja |
---|---|
Status: | new → pending |
comment:2 Changed 11 years ago by
Status: | pending → new |
---|
I retraced my steps and found out that if you enter a % sign in the themeroller (input name bgImgOpacityHover) it gets passed to the css and is used in the image name.
The steps are:
- Go to http://jqueryui.com/themeroller
- Put a number and a % sign in the opacity box ( i put it in [Clickable: hover state] )
- Download the theme using the button underneath Roll Your Own.
- Unpack the zip and go to the images folder and a png with an % in its name should be there (and in the css)
So some input escaping is due :)
comment:3 Changed 11 years ago by
Summary: | % sign in backgroundimage name → ThemeRoller: Clean user data and/or prevent invalid inputs |
---|---|
Type: | bug → feature |
Not escaping, cleaning. You should never type a % in that field.
comment:4 Changed 11 years ago by
Cleaning, that's it. And you should never be allowed to type a % in that field. :)
comment:5 Changed 10 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
Moved to new repo: https://github.com/jquery/download.jqueryui.com/issues/31
What are the manual steps for actually getting to that point?