Sortable: Allow the dimensions of sortable items to be changed in a start event

[ferdyp]

Because the 'start' event is triggered late, any changes to an elements height are not applied to the ui-sortable-helper, which at the time the event triggers has already been created.

Therefor you can not make changes to an elements height before dragging, as the helper will preserve the old height.

The issue is easily fixed by triggering the start-event before creating the helper. Patch:

--- jquery.ui.sortable.js Tue Jan 10 17:12:25 2012 +++ jquery.ui.sortable.js Tue Jan 10 17:12:25 2012 @@ -126,5 +126,2 @@

• Call callbacks
• this._trigger("start", event, this._uiHash());

We only need to call refreshPositions, because the refreshItems call has been moved to mouseCapture

@@ -211,2 +208,5 @@

this.overflowOffset = this.scrollParent.offset();

+ + Call callbacks + this._trigger("start", event, this._uiHash());

[ferdyp]

Can't edit my issue, but here is the patch in a decent format;

--- jquery.ui.sortable.js	Tue Jan 10 17:12:25 2012
+++ jquery.ui.sortable.js	Tue Jan 10 17:12:25 2012
@@ -126,5 +126,2 @@
 
+		//Call callbacks
+		this._trigger("start", event, this._uiHash());
+		
 		//We only need to call refreshPositions, because the refreshItems call has been moved to mouseCapture
@@ -211,2 +208,5 @@
 			this.overflowOffset = this.scrollParent.offset();
-
-		//Call callbacks
-		this._trigger("start", event, this._uiHash());
 

[ferdyp]

And a code example; ​http://jsbin.com/ivuwak/2

Note when dragging 'Item 2' it's height remains as it was, while it's childs have already been hidden.

[ferdyp]

Of course an easier, safer and quicker fix would be to introduce a new beforeStart-event.

[ferdyp]

Any feedback (or action) would be appreciatied.

[Scott González]

This seems like a potentially breaking change. It will be addressed in the rewrite.

[tj.vantoll]

Here's a reduced test case against master: ​http://jsfiddle.net/tj_vantoll/Lwz7z/.