Skip to main content

Search and Top Navigation

#8141 closed enhancement (wontfix)

Opened February 27, 2012 06:38PM UTC

Closed February 27, 2012 07:02PM UTC

Cache raw un-merged options from instantiation in widget for more complicated post-processing

Reported by: fooblah Owned by: fooblah
Priority: minor Milestone: 1.9.0
Component: ui.widget Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:
Description

I added a line:

this.rawOptions = options;

in _createWidget so that I could handle merging some options a special way.

Specifically, I wanted certain arrays nested in user provided options to replace instead of merge.

Attachments (0)
Change History (3)

Changed February 27, 2012 06:49PM UTC by scottgonzalez comment:1

owner: → fooblah
status: newpending

In master (1.9), we never merge arrays. We don't even clone, we reference the original array. How does this affect your use cases?

Changed February 27, 2012 06:58PM UTC by fooblah comment:2

status: pendingnew

Sounds good. I missed that because at https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.widget.js#L210 I missed you guys were calling $.widget.extend and not $.extend.

Thanks.

BTW, is master solid to use for production work yet? I am only using core and widget.

Changed February 27, 2012 07:02PM UTC by scottgonzalez comment:3

resolution: → wontfix
status: newclosed

Ok, if that handles your use cases, then I'll close this as wontfix.

Master is pretty stable. It should actually be more stable than our stable releases.