Search and Top Navigation
#8203 closed feature (fixed)
Opened March 19, 2012 11:23PM UTC
Closed October 27, 2015 01:50PM UTC
Last modified November 04, 2015 04:30AM UTC
Button: Deprecate text option; rename to showLabel
| Reported by: | sp2 | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.12.0 |
| Component: | ui.button | Version: | 1.8.18 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Using 'text' as a boolean to control whether or not the button label is shown isn't very intuitive. It also could easily conflict with other frameworks that might use 'text' to set the label of a variety of controls. Can we change the name to something a little more descriptive, like 'showLabel' or 'showName'?
Attachments (0)
Change History (7)
Changed June 26, 2012 01:24AM UTC by comment:1
| type: | enhancement → feature |
|---|
Changed September 01, 2012 10:19AM UTC by comment:2
I already opened a pull request on GitHub fixing this issue.
Changed October 11, 2012 02:43PM UTC by comment:3
| milestone: | 1.9.0 → 1.11.0 |
|---|
Changed October 15, 2012 09:29PM UTC by comment:4
| status: | new → open |
|---|
We'll look at this when button's API is readdressed in 1.11.
Changed April 01, 2014 06:02PM UTC by comment:5
| milestone: | 1.11.0 → none |
|---|
Changed October 27, 2015 01:50PM UTC by comment:6
| milestone: | none → 1.12.0 |
|---|---|
| resolution: | → fixed |
| status: | open → closed |
| summary: | 'text' is a confusing name for the option → Button: Deprecate text option; rename to showLabel |
Changed November 04, 2015 04:30AM UTC by comment:7
| priority: | minor → blocker |
|---|