Opened 5 years ago

Closed 19 months ago

Last modified 19 months ago

#8203 closed feature (fixed)

Button: Deprecate text option; rename to showLabel

Reported by: sp2 Owned by:
Priority: blocker Milestone: 1.12.0
Component: ui.button Version: 1.8.18
Keywords: Cc:
Blocked by: Blocking:

Description

Using 'text' as a boolean to control whether or not the button label is shown isn't very intuitive. It also could easily conflict with other frameworks that might use 'text' to set the label of a variety of controls. Can we change the name to something a little more descriptive, like 'showLabel' or 'showName'?

Change History (7)

comment:1 Changed 5 years ago by Scott González

Type: enhancementfeature

comment:2 Changed 5 years ago by bernhardsirlinger

I already opened a pull request on GitHub fixing this issue. https://github.com/jquery/jquery-ui/pull/712

comment:3 Changed 5 years ago by Scott González

Milestone: 1.9.01.11.0

comment:4 Changed 5 years ago by tj.vantoll

Status: newopen

We'll look at this when button's API is readdressed in 1.11.

comment:5 Changed 3 years ago by Scott González

Milestone: 1.11.0none

comment:6 Changed 19 months ago by Scott González

Milestone: none1.12.0
Resolution: fixed
Status: openclosed
Summary: 'text' is a confusing name for the optionButton: Deprecate text option; rename to showLabel

comment:7 Changed 19 months ago by Scott González

Priority: minorblocker
Note: See TracTickets for help on using tickets.