Opened 7 years ago

Closed 7 years ago

#8382 closed bug (notabug)

links are using a href="#" for various UI elements

Reported by: andre.steenbergen Owned by: andre.steenbergen
Priority: minor Milestone: 1.9.0
Component: ui.core Version: 1.8.20
Keywords: Cc:
Blocked by: Blocking:

Description

the elements are using a href="#" as a link target. This might give problems when a window.location.hash is already used. Would be nice to change that link to: href="'+window.location.hash+'"

Change History (3)

comment:1 Changed 7 years ago by Scott González

Owner: set to andre.steenbergen
Status: newpending

Please provide actual cases where this is a problem. The existence of <a href"#"> by itself is not a problem, since we prevent the default action of clicks.

comment:2 Changed 7 years ago by andre.steenbergen

Status: pendingnew

We have an offline enabled single page application using the window.location.hash to provide a method to mimic querystring. Querystring is not possible for us, as most web browsers are trying to make web connections when dynamic url's are used.

When JQuery UI components link to # the rest of the "qureystring" is omitted rendering our pages useless. We now do a global replace on href="#" to href="'+window.location.hash+'" keeping the information intact.

comment:3 Changed 7 years ago by Scott González

Resolution: invalid
Status: newclosed

I'm closing as invalid unless you can actually provide specific cases where this happens.

Note: See TracTickets for help on using tickets.