Skip to main content

Search and Top Navigation

#8382 closed bug (notabug)

Opened June 05, 2012 08:31AM UTC

Closed June 05, 2012 01:52PM UTC

links are using a href="#" for various UI elements

Reported by: andre.steenbergen Owned by: andre.steenbergen
Priority: minor Milestone: 1.9.0
Component: ui.core Version: 1.8.20
Keywords: Cc:
Blocked by: Blocking:
Description

the elements are using a href="#" as a link target. This might give problems when a window.location.hash is already used. Would be nice to change that link to: href="'+window.location.hash+'"

Attachments (0)
Change History (3)

Changed June 05, 2012 12:05PM UTC by scottgonzalez comment:1

owner: → andre.steenbergen
status: newpending

Please provide actual cases where this is a problem. The existence of <a href"#"> by itself is not a problem, since we prevent the default action of clicks.

Changed June 05, 2012 01:46PM UTC by andre.steenbergen comment:2

status: pendingnew

We have an offline enabled single page application using the window.location.hash to provide a method to mimic querystring. Querystring is not possible for us, as most web browsers are trying to make web connections when dynamic url's are used.

When JQuery UI components link to # the rest of the "qureystring" is omitted rendering our pages useless. We now do a global replace on href="#" to href="'+window.location.hash+'" keeping the information intact.

Changed June 05, 2012 01:52PM UTC by scottgonzalez comment:3

resolution: → invalid
status: newclosed

I'm closing as invalid unless you can actually provide specific cases where this happens.