Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8605 closed bug (notabug)

jQuery UI Download page missing a dependency for position plugin

Reported by: Myrlyn Owned by: jquery-infrastructure
Priority: minor Milestone: 1.9.0
Component: [meta] ui.downloadbuilder Version: 1.8.23
Keywords: Cc:
Blocked by: Blocking:

Description

I noticed the following bugfix that Scott Gonzalez added roughly three months ago:

https://github.com/jquery/jquery-ui/commit/98772fd0a1094f7fb2fbe1d8a95557bf2b545f6e

We realized this change today on one of our pages using the position plugin which uses the deprecated .curCss method. After finding Scott's fix in the jQuery UI core file, we realized that position now has a dependency upon core. Wanting to double check this dependency, I went over to the jQuery UI download page, and set it to do a custom download. I deselected all components, and then selected just the position component. Typically, if a component has a dependency, the other components it relies upon are automatically selected for the user. this didn't happen in this case. Am I correct that this is a bug with the download page now that position has this reliance upon core?

Thanks! Keith

Change History (2)

comment:1 Changed 7 years ago by Scott González

Resolution: invalid
Status: newclosed

I'm not sure why you think that bug fix makes position dependent on core; that would be quite silly. If you download just position from the download builder, it will work. Position handles missing $.curCSS on its own.

comment:2 Changed 7 years ago by Myrlyn

Sorry, our version where we found the problem was 1.8.20. And I missed the correction in the current version. Thanks.

Note: See TracTickets for help on using tickets.