Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#8720 closed bug (worksforme)

Fix failing position test in IE8

Reported by: Jörn Zaefferer Owned by: mikesherov
Priority: minor Milestone: git
Component: [meta] ui.dev Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:

Change History (6)

comment:1 Changed 7 years ago by mikesherov

Owner: set to mikesherov
Status: newassigned

comment:2 Changed 7 years ago by mikesherov

OK, so when I can modify testswarm to the point that it no longer uses an IFRAME (https://github.com/jquery/testswarm/issues/195), but rather redirects, I can revert the changes introduced by Scott to get us green.

comment:3 Changed 7 years ago by Scott González

Milestone: 1.10.0git
Summary: Figure out why position tests are failing in IE8Fix failing position test in IE8

The failing test is conditionally removed in IE right now.

comment:4 Changed 7 years ago by Scott González

Component: [meta] ui.build[meta] ui.dev

comment:5 Changed 6 years ago by Jörn Zaefferer

Resolution: worksforme
Status: assignedclosed

This was fixed a while ago. Can't tell when or how. Closing as 'worksforme' since we don't need it in any changelog anyway.

comment:6 Changed 6 years ago by Jörn Zaefferer

Actually I should have read Scott's earlier comment. The conditional removal is still there. Since we didn't change how TestSwarm runs tests (via iframe), we'll have to leave it like that.

Note: See TracTickets for help on using tickets.