#8772 closed bug (fixed)

Opened November 05, 2012 11:57AM UTC

Closed November 22, 2012 12:19AM UTC

Slider: Incorrect UI state when disabled at init

Reported by: samycookie Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.slider Version: 1.8.20
Keywords: haspatch Cc:
Blocked by: Blocking:
Description

The slider widget have not the good UI design when disabled at creation.

see http://jsfiddle.net/mCFv5/7/

Attachments (0)
Change History (6)

Changed November 05, 2012 12:20PM UTC by samycookie comment:1

a possible solution:

https://github.com/SamyCookie/jquery-ui/commit/ade3cc5dfb34abf0ad870e909041dac7939b3e6e

Changed November 05, 2012 01:31PM UTC by tj.vantoll comment:2

keywords: → haspatch
status: new → open
summary: Wrong slider UI state when disabled at init → Slider: Incorrect UI state when disabled at init

Thanks for taking the time to contribute to the jQuery UI project. The issue here is that when the slider is created as disabled it is not getting the "ui-state-disabled" class. If you would like to submit your fix please create a branch on your fork and submit a pull request.

Please include a unit test showing that before the slider did not have the appropriate class upon initialization and after your fix is applied it does.

Changed November 16, 2012 02:25PM UTC by samycookie comment:3

The branch created for this issue:

https://github.com/SamyCookie/jquery-ui/tree/bugfix_8772

Changed November 16, 2012 04:26PM UTC by scottgonzalez comment:4

@samycookie Thanks, can you send a pull request?

Changed November 16, 2012 04:56PM UTC by samycookie comment:5

I updated the test case, and pull requested my branch.

https://github.com/jquery/jquery-ui/pull/824/

Changed November 22, 2012 12:19AM UTC by Samuel Bovée comment:6

resolution: → fixed
status: open → closed

Slider: factorize code with Widget method call. Fixed #8772 - Wrong slider UI state when disabled at init

Changeset: cb748b4a6f32aa5748d6777e7871c96f70ad2207