#8792 closed bug (fixed)

Opened November 09, 2012 09:14AM UTC

Closed March 08, 2013 09:58PM UTC

Last modified March 08, 2013 10:29PM UTC

Sortable: Issue with floated items in connected lists

Reported by: BlazeCell Owned by: mikesherov
Priority: minor Milestone: 1.10.2
Component: ui.sortable Version: 1.9.1
Keywords: Cc:
Blocked by: Blocking:
Description

The latest version of Sortable breaks when sorting floated items.

It will only allow items to to be placed on the last row of a container.

Attachments (0)
Change History (21)

Changed November 09, 2012 09:35AM UTC by BlazeCell comment:1

Sortable: Reverted a line back to 1.8.24 version. Fixed #8792 - Sortable on floating items only allows items to be placed on the last row

The following github pull request has the fix:

https://github.com/jquery/jquery-ui/pull/818

Changed November 09, 2012 11:28AM UTC by tj.vantoll comment:2

owner: → BlazeCell
status: new → pending

Thanks for taking the time to contribute to the jQuery UI project! Please provide a complete reduced test case on jsFiddle to help us assess your ticket.

Additionally, be sure to test against the git version of both jQuery UI and jQuery to ensure the issue still exists. To get you started, use this boilerplate: http://jsfiddle.net/ZgAqH/ Open the link and click to "Fork" (in the top menu) to get started.

Also the line that you're reverting (https://github.com/jquery/jquery-ui/commit/bae06d2b) was part of a change to fix #8572, #8573, and #8574.

Changed November 09, 2012 07:07PM UTC by BlazeCell comment:3

status: pending → new
Additionally, be sure to test against the git version of both jQuery UI and jQuery to ensure the issue still exists. To get you started, use this boilerplate: http://jsfiddle.net/ZgAqH/ Open the link and click to "Fork" (in the top menu) to get started.

Thanks for the jsfiddle boilerplate, that helps to get things up and running quickly. =)

I've put together a jsfiddle with the same code I've performed my internal tests with:

http://jsfiddle.net/BlazeCell/QkUft/8/

You can see the issue when you try to sort any of the items. The placeholder indicates that the sort action will drop the item on the last row, regardless of which sortable container you hover your mouse over. And when you release the mouse, the item will indeed be sorted to the bottom row.

Changed November 10, 2012 03:11AM UTC by tj.vantoll comment:4

keywords: → haspatch
status: new → open
summary: Sortable on floating items only allows items to be placed on the last row. → Sortable: Issue with floated items in connected lists

Minified this one down a little more - http://jsfiddle.net/tj_vantoll/rRDba/. I can confirm the issue in 1.9.1 and that it functions fine in 1.8.24. The issue only occurs when the 

connectWith
option is set and the items are floated.

Changed November 13, 2012 01:45AM UTC by tj.vantoll comment:5

#8810 is possibly related to this.

Changed November 13, 2012 04:44AM UTC by arpowers comment:6

_comment0: I can verify that #8810 is probably the same bug. \ \ Another JSFiddle with the issue: \ http://jsfiddle.net/a7rxv/ → 1352782221512446

I can verify that #8810 is probably the same bug.

Another JSFiddle with the issue:

http://jsfiddle.net/arpowers/a7rxv/1/

Changed November 13, 2012 01:18PM UTC by tj.vantoll comment:7

#8810 is a duplicate of this ticket.

Changed November 23, 2012 03:36AM UTC by mikesherov comment:8

keywords: haspatch
owner: BlazeCell → mikesherov
status: open → assigned

Changed December 14, 2012 02:34AM UTC by tj.vantoll comment:9

#8909 is a duplicate of this ticket.

Changed December 27, 2012 01:28PM UTC by tj.vantoll comment:10

#8936 is a duplicate of this ticket.

Changed January 08, 2013 08:20PM UTC by arpowers comment:11

Is there any update on the fix for this?

Changed January 25, 2013 09:23PM UTC by tj.vantoll comment:12

milestone: 1.10.0 → none

Changed February 02, 2013 02:39AM UTC by tj.vantoll comment:13

Possible duplicate: #9041.

Changed February 08, 2013 03:57AM UTC by tj.vantoll comment:14

#9070 is a duplicate of this ticket.

Changed February 08, 2013 03:58AM UTC by tj.vantoll comment:15

Another test case from #9070: http://jsfiddle.net/tj_vantoll/vVrzf/

Changed February 17, 2013 05:24AM UTC by zhizhangchen comment:16

I've sent a pull request to fix this problem: https://github.com/jquery/jquery-ui/pull/916

Changed February 19, 2013 11:41AM UTC by tj.vantoll comment:17

#9099 is a duplicate of this ticket.

Changed February 20, 2013 03:10AM UTC by tj.vantoll comment:18

We should check whether the fix addresses #7045 & #7501 as they are similar issues.

Changed February 26, 2013 01:18PM UTC by tj.vantoll comment:19

#9124 is a duplicate of this ticket.

Changed March 08, 2013 09:58PM UTC by John Chen comment:20

resolution: → fixed
status: assigned → closed

Sortable: Skip items that are not at the same line as the cursor when floating. Fixes #8792: Issue with floated items in connected lists.

Changeset: 89473f6557662d905a63faa3ae3520bf3715a7e8

Changed March 08, 2013 10:29PM UTC by mikesherov comment:21

milestone: none → 1.10.2