#8802 closed feature (fixed)

Opened November 09, 2012 06:00PM UTC

Closed December 04, 2013 04:09PM UTC

Dev: Track down uses of .bind() inside widgets

Reported by: scottgonzalez Owned by:
Priority: minor Milestone: git
Component: [meta] ui.dev Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:
Description

Now that _on() has the suppressDisabledCheck flag, we should be able to stop using .bind() directly.

Attachments (0)
Change History (8)

Changed November 09, 2012 06:01PM UTC by scottgonzalez comment:1

milestone: 1.10.0 → git
status: new → open

Changed November 15, 2012 03:19PM UTC by jzaefferer comment:2

Does "track down" include fixing?

Button uses plenty of 

bind()

Changed November 15, 2012 03:23PM UTC by scottgonzalez comment:3

Replying to [comment:2 joern.zaefferer]:

Does "track down" include fixing?

Not necessarily, it depends on the number of uses. It's entirely possible that separate tickets will be created for fixing individual widgets.

Changed November 15, 2012 04:43PM UTC by jzaefferer comment:4

Dialog uses bind, I'll clean that up soon(ish).

Droppable has one bind call.

Menu has a single bind call, can be replaced now.

Mouse has several bind calls.

That should be all.

Changed November 15, 2012 04:46PM UTC by jzaefferer comment:5

_comment0: Also need to look for usage of shorthands like [[[click]]], [[[mousedown]]] etc. We have those sometimes on generated elements. → 1352998066148363

Also need to look for usage of shorthands like [[[click]]], [[[mousedown]]] etc. We have those sometimes on generated elements. Though if there's no need for namespacing to begin with, maybe we don't have to bother at all.

Changed December 03, 2013 05:37PM UTC by jzaefferer comment:6

Current status:

  • Droppable has one bind call
  • Menu is still using bind, really needs to switch to suppressDisabledCheck
  • Mouse still uses bind

Changed December 03, 2013 08:55PM UTC by jzaefferer comment:7

The one in menu is gone. Removed the entire binding, since we don't need it anymore - Menu doesn't have anchors anymore, so there's no default behaviour to prevent.

Changed December 04, 2013 04:09PM UTC by jzaefferer comment:8

resolution: → fixed
status: open → closed

Menu was the last relevant usage of bind. Others are in widgets that we're rewriting anyway (datepicker, button, interactions).