Opened 10 years ago
Closed 9 years ago
#8802 closed feature (fixed)
Dev: Track down uses of .bind() inside widgets
| Reported by: | Scott González | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | git |
| Component: | [meta] ui.dev | Version: | git (not yet released) |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Now that _on() has the suppressDisabledCheck flag, we should be able to stop using .bind() directly.
Change History (8)
comment:1 Changed 10 years ago by
| Milestone: | 1.10.0 → git |
|---|---|
| Status: | new → open |
comment:2 follow-up: 3 Changed 10 years ago by
comment:3 Changed 10 years ago by
Replying to joern.zaefferer:
Does "track down" include fixing?
Not necessarily, it depends on the number of uses. It's entirely possible that separate tickets will be created for fixing individual widgets.
comment:4 Changed 10 years ago by
Dialog uses bind, I'll clean that up soon(ish).
Droppable has one bind call.
Menu has a single bind call, can be replaced now.
Mouse has several bind calls.
That should be all.
comment:5 Changed 10 years ago by
Also need to look for usage of shorthands like [click?], [mousedown?] etc. We have those sometimes on generated elements.
comment:6 Changed 9 years ago by
Current status:
- Droppable has one bind call
- Menu is still using bind, really needs to switch to suppressDisabledCheck
- Mouse still uses bind
comment:7 Changed 9 years ago by
The one in menu is gone. Removed the entire binding, since we don't need it anymore - Menu doesn't have anchors anymore, so there's no default behaviour to prevent.
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Menu was the last relevant usage of bind. Others are in widgets that we're rewriting anyway (datepicker, button, interactions).
Does "track down" include fixing?
Button uses plenty of
bind()