Skip to main content

Search and Top Navigation

#8828 closed bug (fixed)

Opened November 18, 2012 07:30AM UTC

Closed November 22, 2012 12:25AM UTC

Last modified November 23, 2012 10:10AM UTC

Button: Refresh does not re-enable disabled button.

Reported by: ezyang Owned by: tj.vantoll
Priority: minor Milestone: 1.9.2
Component: ui.button Version: 1.9.1
Keywords: regression haspatch Cc:
Blocked by: Blocking:
Description

See example: http://jsfiddle.net/U2Gmm/2/

It does, however, manage to capture enabled to disabled transition.

Attachments (0)
Change History (13)

Changed November 18, 2012 07:58PM UTC by scottgonzalez comment:1

component: ui.coreui.button
status: newopen
summary: Refresh does not re-enabled disabled button.Button: Refresh does not re-enabled disabled button.

Changed November 18, 2012 07:59PM UTC by scottgonzalez comment:2

summary: Button: Refresh does not re-enabled disabled button.Button: Refresh does not re-enable disabled button.

Changed November 19, 2012 01:55AM UTC by tj.vantoll comment:3

resolution: → notabug
status: openclosed

@ezyang The example you provided has a JS error because there is no

refresh
on
$.fn
. In order to call
button
's
refresh
method you must use
$('button').button('refresh')
, which works fine - http://jsfiddle.net/tj_vantoll/hWkvs/.

If you have an example that shows this issue without a JS error please comment and we can reinvestigate.

Changed November 19, 2012 02:28AM UTC by ezyang comment:4

Oops, sorry about the typo! It seems that the older version of jQuery UI handles it properly, but not the latest: http://jsfiddle.net/U2Gmm/3/

Changed November 19, 2012 02:04PM UTC by scottgonzalez comment:5

keywords: → regression
resolution: notabug
status: closedreopened

Interestingly, this is a regression in 1.9.1

Changed November 19, 2012 02:04PM UTC by scottgonzalez comment:6

status: reopenedopen

Changed November 19, 2012 07:51PM UTC by tj.vantoll comment:7

owner: → tj.vantoll
status: openassigned

Since this is a 1.9.1 regression this was likely caused by my change here - https://github.com/jquery/jquery-ui/commit/5e24a1ce4b337830b37511305a6ddefe797fd40c. I'll look into this.

Changed November 19, 2012 08:02PM UTC by mikesherov comment:8

So, just as a point of strategy, I'd like to see this NOT rolled back, but adding even more tests to keep both fixes, if possible.

Changed November 19, 2012 08:15PM UTC by tj.vantoll comment:9

@mikesherov Agreed. I'm on it.

Changed November 19, 2012 08:45PM UTC by tj.vantoll comment:10

keywords: regressionregression haspatch

Changed November 22, 2012 12:25AM UTC by TJ VanToll comment:11

resolution: → fixed
status: assignedclosed

Button: Fixing handling of the disabled options on refresh method calls. Fixed #8828 - Button: Refresh does not re-enable disabled button.

Changeset: 93abe02b6052143fac30393291da3fc254bde996

Changed November 23, 2012 10:10AM UTC by TJ VanToll comment:12

Button: Fixing handling of the disabled options on refresh method calls. Fixed #8828 - Button: Refresh does not re-enable disabled button.

(cherry picked from commit 93abe02b6052143fac30393291da3fc254bde996)

Changeset: 8def77cb5cfefb733874d15a2294f02fc5ae78ae

Changed November 23, 2012 10:10AM UTC by jzaefferer comment:13

milestone: 1.10.01.9.2

Merged into 1-9-stable.