Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9008 closed bug (notabug)

Dialog: Titlebar close button shows title attribute "close" on mouse hover

Reported by: kienz Owned by: kienz
Priority: minor Milestone: none
Component: ui.dialog Version: 1.10.0
Keywords: Cc:
Blocked by: Blocking:

Description

The ui.button element in the titlebar of the ui.dialog shows "close" tooltip on hover over the icon-element.

Change History (6)

comment:1 Changed 7 years ago by Scott González

Owner: set to kienz
Status: newpending

Why do you think this is a bug?

comment:2 Changed 7 years ago by kienz

Status: pendingnew

I think usually there are no tooltips on buttons. Or I'm wrong? For what is this useful? Why you don't use aria-label="close"?

comment:3 Changed 7 years ago by Scott González

Status: newpending

The button widget applies a title to all buttons that only use an icon. Why is this not useful?

comment:4 Changed 7 years ago by kienz

Status: pendingnew

Ok, i saw that you can set closeText: null. After that the title attribute is null - why is it set by default to "close"?

comment:5 Changed 7 years ago by Scott González

Resolution: notabug
Status: newclosed

Because that's a sane value that has meaning.

comment:6 Changed 7 years ago by drew.waddell

I also ran into this, it is sane for it to be close if it were to be something but wouldn't you think a user would have to be insane not to know what X does at the top of a dialog?

I'll probably set the closeText to null as suggested but if close is to be the default why wouldn't it be Close with a capital C, just curious.

Thanks, Drew

Note: See TracTickets for help on using tickets.