Menu item click causes page scroll

[tooparam]

Whenever I choose an item in the menu, it causes whole page scroll.

[tj.vantoll]

Hi tooparam,

Thanks for taking the time to contribute to the jQuery UI project. In order to assess this ticket we need a reduced test case that shows the issue. You can use this as a starting point ​http://jsfiddle.net/tj_vantoll/jCTEP/.

Thanks.

[tooparam]

here is the example test case

​http://jsfiddle.net/jCTEP/3/

[tj.vantoll]

Ok I see this. This is fixed easily enough be adding a preventDefault() call but I'm guessing there might be some focus related reason we're not doing that here (​https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.menu.js#L66)... so I'll wait for others to chime in.

If you need a workaround just add an event handler that prevents the default action: ​http://jsfiddle.net/tj_vantoll/FT5K9/.

[tj.vantoll]

scott.gonzalez / kborchers

We had chatted about his one in IRC awhile ago (​http://irc.jquery.org/%23jqueryui-dev/%23jqueryui-dev_20130325.log.html) but I don't know if we ever came to a consensus over what we wanted to do here. Thoughts?

[Scott González]

My thought is that we should stop using anchors and just let the main element be the focusable content. I don't remember why anchors were used.

[tj.vantoll]

Replying to scott.gonzalez:

My thought is that we should stop using anchors and just let the main element be the focusable content. I don't remember why anchors were used.

Seems reasonable. I'm going to mark this as valid because I do think the described behavior is a bug.

[Scott González]

Anchors are no longer used as of 1.11.0. See #10130.