Skip to main content

Search and Top Navigation

#9189 closed bug (fixed)

Opened March 27, 2013 01:28PM UTC

Closed March 27, 2013 07:24PM UTC

Last modified May 02, 2013 12:13PM UTC

Accordion: refresh() method incorrectly opens collapsed accordion

Reported by: mls81 Owned by:
Priority: minor Milestone: 1.10.3
Component: ui.accordion Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:
Description

When an accordion in jQuery UI 1.10.2 is in a fully collapsed state (i.e. no panels are open, 'collapsible' is true and 'active' is false), calling 'refresh' on the accordion will fire the 'activate' event on the first panel in the accordion even though the panel was not clicked or selected, causing that panel to open.

A demo of the bug is at http://jsfiddle.net/3dsxK/

The reason is a missing 'else' in jquery.ui.accordion.js on line 226.

This is wrong:

} if ( options.active === false ) {

This is right:

} else if ( options.active === false ) {

Attachments (0)
Change History (5)

Changed March 27, 2013 07:23PM UTC by scottgonzalez comment:1

milestone: none1.11.0
status: newopen
summary: Accordion fires 'activate' event on the first panel of a collapsed accordion whenever the 'refresh' method is called.Accordion: refresh() method incorrectly opens collapsed accordion

Changed March 27, 2013 07:24PM UTC by Scott González comment:2

resolution: → fixed
status: openclosed

Accordion: Maintain collapsed state on refresh. Fixes #9189 - Accordion: refresh() method incorrectly opens collapsed accordion.

Changeset: 5a8596cdf3baa4d835e588cda9060a0537236c71

Changed April 17, 2013 06:57PM UTC by Scott Gonz��lez comment:3

Accordion: Maintain collapsed state on refresh. Fixes #9189 - Accordion: refresh() method incorrectly opens collapsed accordion.

(cherry picked from commit 5a8596cdf3baa4d835e588cda9060a0537236c71)

Changeset: a93ad182c837ef6c46323092a5538355e7ee3a7c

Changed April 17, 2013 06:57PM UTC by scottgonzalez comment:4

milestone: 1.11.01.10.3

Changed May 02, 2013 12:13PM UTC by tj.vantoll comment:5

#9268 is a duplicate of this ticket.