Opened 6 years ago

Closed 6 years ago

#9211 closed bug (notabug)

`heightStyle: 'fill'` does not works properly with vertical tabs

Reported by: meden Owned by: meden
Priority: minor Milestone: none
Component: ui.tabs Version: 1.9.2
Keywords: Cc:
Blocked by: Blocking:

Description

Creating vertical tabs as described in Tabs Demo breaks the refresh with heightStile: 'fill'.

The maxHeight available is indeed calculated subtracting all non-panels heights from tab container's height (see https://github.com/jquery/jquery-ui/blob/1-9-stable/ui/jquery.ui.tabs.js#L521). This is correct if ui-tabs-nav is on top, but it causes the height to be reduced to ui-tabs-nav's height if the navbar is on the side.

I file this behavior as bug because vertical tabs are reported as (official) example in Tabs Demo page.

Change History (3)

comment:1 Changed 6 years ago by Scott González

Owner: set to meden
Status: newpending

I file this behavior as bug because vertical tabs are reported as (official) example in Tabs Demo page.

In the sense that it's hosted on our site, I suppose that makes it "official". But I'm not sure what support you're expected for an "official" demo. The demo works as is. It's clearly quite customized and there's no built-in support for vertical tabs. Do you have a proposal for how this should be implemented?

comment:2 in reply to:  1 Changed 6 years ago by meden

Status: pendingnew

Replying to scott.gonzalez:

In the sense that it's hosted on our site, I suppose that makes it "official". But I'm not sure what support you're expected for an "official" demo.


Actually not much... But IMHO it was better to point out the issue (and stick it to vertical layout).

Do you have a proposal for how this should be implemented?


I don't, by now... At least, nothing that would not break encapsulation (a check if tabs have .ui-tabs-vertical class, in which case ui-tabs-nav should not be considered while calculating height. Dirty hack...).

So, the only clean way seems to be implementing a layout: [horizontal|vertical] option... ;)

Maybe it would be better put at least a warning on the demo, so to avoid surprises to user.

comment:3 Changed 6 years ago by Scott González

Resolution: notabug
Status: newclosed

We're not going to be adding the layout option, and we're not going to write a hack around a class that isn't even supported by the widget. If you come up with an idea for how to implement this in a clean way, let us know.

Note: See TracTickets for help on using tickets.