Search and Top Navigation
#9423 closed bug (notabug)
Opened July 12, 2013 10:26AM UTC
Closed July 15, 2013 12:14PM UTC
No buttons in Dialogs with 1.10.2
| Reported by: | pjchilds | Owned by: | pjchilds |
|---|---|---|---|
| Priority: | minor | Milestone: | none |
| Component: | ui.dialog | Version: | 1.10.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
init dialog with button and creates an exception
Attachments (0)
Change History (5)
Changed July 12, 2013 10:27AM UTC by comment:1
Changed July 12, 2013 12:24PM UTC by comment:2
| owner: | → pjchilds |
|---|---|
| status: | new → pending |
Hi pjchilds,
Thanks for taking the time to contribute to the jQuery UI project. Could you please create a test case that shows the issue you're experiencing? I'm not seeing any problems: http://jsfiddle.net/tj_vantoll/QqyUN/.
Changed July 12, 2013 12:34PM UTC by comment:3
| description: | init dialog with button and creates an exception \ \ here is a diff \ \ *** target/jquery/jquery-ui-1.10.3/ui/jquery-ui.js 2013-05-03 09:20:58.000000000 +0930 \ --- target/docs/js/jquery-ui.js 2013-07-12 19:50:14.000000000 +0930 \ *************** \ *** 649,657 **** \ this.options[ key ] = value; \ \ if ( key === "disabled" ) { \ ! this.widget() \ ! .toggleClass( this.widgetFullName + "-disabled ui-state-disabled", !!value ) \ ! .attr( "aria-disabled", value ); \ this.hoverable.removeClass( "ui-state-hover" ); \ this.focusable.removeClass( "ui-state-focus" ); \ } \ --- 649,656 ---- \ this.options[ key ] = value; \ \ if ( key === "disabled" ) { \ ! this.widget().toggleClass( this.widgetFullName + "-disabled ui-state-disabled", !!value ); \ ! this.widget().attr( "aria-disabled", value ); \ this.hoverable.removeClass( "ui-state-hover" ); \ this.focusable.removeClass( "ui-state-focus" ); \ } → init dialog with button and creates an exception |
|---|
Changed July 15, 2013 05:16AM UTC by comment:4
| status: | pending → new |
|---|
I was unable to reproduce using a minimal code set. On further investigation a third-party plugin was overwriting toggleClass causing this fault.
Please close - No Fault Found.
Changed July 15, 2013 12:14PM UTC by comment:5
| resolution: | → notabug |
|---|---|
| status: | new → closed |
*** target/jquery/jquery-ui-1.10.3/ui/jquery-ui.js 2013-05-03 09:20:58.000000000 +0930 --- target/docs/js/jquery-ui.js 2013-07-12 19:50:14.000000000 +0930 *************** *** 649,657 **** this.options[ key ] = value; if ( key === "disabled" ) { ! this.widget() ! .toggleClass( this.widgetFullName + "-disabled ui-state-disabled", !!value ) ! .attr( "aria-disabled", value ); this.hoverable.removeClass( "ui-state-hover" ); this.focusable.removeClass( "ui-state-focus" ); } --- 649,656 ---- this.options[ key ] = value; if ( key === "disabled" ) { ! this.widget().toggleClass( this.widgetFullName + "-disabled ui-state-disabled", !!value ); ! this.widget().attr( "aria-disabled", value ); this.hoverable.removeClass( "ui-state-hover" ); this.focusable.removeClass( "ui-state-focus" ); }