Opened 6 years ago

Closed 6 years ago

#9423 closed bug (notabug)

No buttons in Dialogs with 1.10.2

Reported by: pjchilds Owned by: pjchilds
Priority: minor Milestone: none
Component: ui.dialog Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by Scott González)

init dialog with button and creates an exception

Change History (5)

comment:1 Changed 6 years ago by pjchilds

*** target/jquery/jquery-ui-1.10.3/ui/jquery-ui.js	2013-05-03 09:20:58.000000000 +0930
--- target/docs/js/jquery-ui.js	2013-07-12 19:50:14.000000000 +0930
***************
*** 649,657 ****
  		this.options[ key ] = value;

  		if ( key === "disabled" ) {
! 			this.widget()
! 				.toggleClass( this.widgetFullName + "-disabled ui-state-disabled", !!value )
! 				.attr( "aria-disabled", value );
  			this.hoverable.removeClass( "ui-state-hover" );
  			this.focusable.removeClass( "ui-state-focus" );
  		}
--- 649,656 ----
  		this.options[ key ] = value;

  		if ( key === "disabled" ) {
! 			this.widget().toggleClass( this.widgetFullName + "-disabled ui-state-disabled", !!value );
! 			this.widget().attr( "aria-disabled", value );
  			this.hoverable.removeClass( "ui-state-hover" );
  			this.focusable.removeClass( "ui-state-focus" );
  		}

comment:2 Changed 6 years ago by tj.vantoll

Owner: set to pjchilds
Status: newpending

Hi pjchilds,

Thanks for taking the time to contribute to the jQuery UI project. Could you please create a test case that shows the issue you're experiencing? I'm not seeing any problems: http://jsfiddle.net/tj_vantoll/QqyUN/.

comment:3 Changed 6 years ago by Scott González

Description: modified (diff)

comment:4 Changed 6 years ago by pjchilds

Status: pendingnew

I was unable to reproduce using a minimal code set. On further investigation a third-party plugin was overwriting toggleClass causing this fault.

Please close - No Fault Found.

comment:5 Changed 6 years ago by tj.vantoll

Resolution: notabug
Status: newclosed
Note: See TracTickets for help on using tickets.