Search and Top Navigation
#9465 closed feature (fixed)
Opened July 31, 2013 02:36PM UTC
Closed February 20, 2014 02:18PM UTC
Add Bower Support
| Reported by: | scottgonzalez | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.11.0 |
| Component: | [meta] ui.dev | Version: | 1.10.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
bower install jquery-ui should install the individual source files with @VERSION replaced. Bower users will be expected to handle minification and concatenation on their own. This should be easily accomplies with the addition of AMD (#9464).
~~When this is ready, we'll need to claim ownership of the jquery-ui component in the Bower registry: https://github.com/bower/bower/issues/120~~
We decided to keep the "jqueryui" package as-is, instead of trying to take it over. That avoids various problems with backwards compatibility for existing bower users.
Attachments (0)
Change History (8)
Changed July 31, 2013 02:38PM UTC by comment:1
| milestone: | none → 1.11.0 |
|---|---|
| priority: | minor → blocker |
| status: | new → open |
Changed September 11, 2013 07:43PM UTC by comment:2
| milestone: | 1.11.0 → 1.12.0 |
|---|
Not super useful without AMD support, so moving this as well.
Changed January 30, 2014 08:31PM UTC by comment:3
| milestone: | 1.12.0 → 1.11.0 |
|---|
Changed February 01, 2014 04:30AM UTC by comment:4
I looked into this a bit. This is more or less the
bower.jsonwe need (minus the dev dependencies, which are covered by #9507):
{
"name": "jquery-ui",
"version": "1.11.0pre",
"ignore": [
"**/.*",
"build",
"demos",
"dist",
"external",
"tests"
],
"dependencies": {
"jquery": ">=1.6"
}
}
Other than the version, I'm not sure how much value there is in generating this file. The name will almost certainly never change, and we don't have a list of ignorable files, or our jQuery core version dependency stored anywhere currently.
Changed February 03, 2014 04:12PM UTC by comment:5
| _comment0: | We do have the jQuery core dependency listed [https://github.com/jquery/jquery-ui/blob/74f38b4e2f31fc16c6951cbb8a96530f29ed6488/build/tasks/build.js#L65 in a grunt task]. We should either move that to a separate file and populate both from that or just have the manifest pull the version out of `bower.json`. Once we start using Bower, I'm ok with treating it as a canonical source for information that doesn't belong on `package.json`. → 1391444049335201 |
|---|
We do have the jQuery core dependency listed in a grunt task. We should either move that to a separate file and populate both from that or just have the manifest pull the version out of bower.json. Once we start using Bower, I'm ok with treating it as a canonical source for information that doesn't belong in package.json.
Changed February 05, 2014 05:18PM UTC by comment:6
Changed February 18, 2014 06:28PM UTC by comment:7
| description: | `bower install jquery-ui` should install the individual source files with `@VERSION` replaced. Bower users will be expected to handle minification and concatenation on their own. This should be easily accomplies with the addition of AMD (#9464). \ \ When this is ready, we'll need to claim ownership of the `jquery-ui` component in the Bower registry: https://github.com/bower/bower/issues/120 → `bower install jquery-ui` should install the individual source files with `@VERSION` replaced. Bower users will be expected to handle minification and concatenation on their own. This should be easily accomplies with the addition of AMD (#9464). \ \ ~~When this is ready, we'll need to claim ownership of the `jquery-ui` component in the Bower registry: https://github.com/bower/bower/issues/120~~ \ \ We decided to keep the "jqueryui" package as-is, instead of trying to take it over. That avoids various problems with backwards compatibility for existing bower users. |
|---|