Search and Top Navigation
#9539 closed bug (invalid)
Opened September 05, 2013 05:37PM UTC
Closed September 24, 2013 08:39AM UTC
1.11.0 (git) -- Recent ui.mouse change on git breaks ui.draggable on iPad
| Reported by: | johnnyshields | Owned by: | johnnyshields |
|---|---|---|---|
| Priority: | minor | Milestone: | none |
| Component: | ui.mouse | Version: | git (not yet released) |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
This commit:
in ui.mouse.js line 117:
// Iframe mouseup check - mouseup occurred in another document
else if ( !event.which ) {
return this._mouseUp( event );
}
These added lines break ui.draggable on iPad (I'm using touch punch). Previously, dragging worked as expected on iPad. After adding these lines, when I touch a draggable element, draggable appears to start but then immediately stop.
Removing the lines listed above fixes the issue.
Attachments (0)
Change History (7)
Changed September 05, 2013 05:38PM UTC by comment:1
| _comment0: | ^^^ above is formatted incorrectly. The affected lines are: \ \ {{{ \ // Iframe mouseup check - mouseup occurred in another document \ else if ( !event.which ) { \ return this._mouseUp( event ); \ } \ }}} → 1378402772861916 |
|---|
Changed September 08, 2013 09:06PM UTC by comment:2
| owner: | → johnnyshields |
|---|---|
| status: | new → pending |
To be clear here, you're not seeing an issue with jQuery UI itself, just that the changes made in git have broke touch punch - correct?
Changed September 08, 2013 09:42PM UTC by comment:3
| _comment0: | I have not observed an issue on non-mobile platforms, but have not tested extensively. Regardless, touch-punch is widely used and this should be fixed before release. → 1378676662256411 |
|---|---|
| status: | pending → new |
I have not observed an issue on non-mobile platforms, but have not tested extensively. Regardless, touch-punch is widely used and this should be fixed before release. It's likely that these lines will impact similar mobile frameworks.
Changed September 10, 2013 01:28AM UTC by comment:4
| status: | new → pending |
|---|
I'm not seeing this issue on iOS6 - http://jsfiddle.net/tj_vantoll/38UFh/.
Can you please alter my test case to show the issue you're experiencing?
Changed September 10, 2013 02:04AM UTC by comment:5
| status: | pending → new |
|---|
Huh I played around with it but couldn't reproduce on JS Fiddle. Bizarre...
I'll have to take deeper look at what's going on in my app, will need awhile for this.
Changed September 10, 2013 02:13AM UTC by comment:6
| status: | new → pending |
|---|
Ok, if you can get a make reproducible test case we can investigate.
Changed September 24, 2013 08:39AM UTC by comment:7
| resolution: | → invalid |
|---|---|
| status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Code above is formatted incorrectly. The affected lines are:
// Iframe mouseup check - mouseup occurred in another document else if ( !event.which ) { return this._mouseUp( event ); }