Opened 7 years ago

Closed 7 years ago

#9567 closed bug (patcheswelcome)

UI Dialog position not working in IE9 when margin:auto

Reported by: jacobwsmith Owned by: jacobwsmith
Priority: minor Milestone: none
Component: ui.dialog Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:

Description

In IE 9 on Windows 7 when the .ui-dialog { margin:auto; } is set in the css the dialog script will not position itself correctly.

I'm seeing this in 1.10.3 and this example http://jsfiddle.net/jacobwsmith/KsLEQ/ with 1.9.1.

Change History (3)

comment:1 Changed 7 years ago by Scott González

Owner: set to jacobwsmith
Status: newpending

Why are you putting margin: auto on the dialog? We don't support auto-width for dialogs and the dialog needs to control it's own sizing in order to work properly.

comment:2 Changed 7 years ago by jacobwsmith

Status: pendingnew

That is a good question. We have a number of uses for the ui-dialog. Some with more complicated and different transitions. On one of our larger pages we ended up having some style assigned to it with margin: 0 auto 0; Seems this is a problem with our code...? Strange how ie9 is the only browser with this problem, even ie8 works fine. Thought this would be of interest. Perhaps not a bug. Thanks.

comment:3 Changed 7 years ago by Scott González

Resolution: patcheswelcome
Status: newclosed

Yeah, it's odd that this is only a problem in IE9. Since the margins can't actually be used to center the dialog (the dialog has to control its position and dimensions), I don't think we'll want to work around this. However, if someone wants to send a pull request, we can review it and determine if it makes sense to include based on size and complexity.

Note: See TracTickets for help on using tickets.