Release: Generate quick downloads

[Scott González]

The code and theme zips need to be generated during release. The quick download that Download Builder generates right now doesn't seem to be linked from anywhere. That task should probably just generate the two zips we care about.

[Jörn Zaefferer]

Just discussed this with Rafael, our suggestion is as follows. If okay, Rafael can work on that.

Update ​build-packages task to output jquery-ui-[VERSION].zip (without the ".custom" postfix it currently has). Output is already consistent with a custom download, just wrapped in "development-bundle" folder, additional (concat/min) css and js folders and docs (instead of tests). Therefore no need to change the content.

Also extend the build-packages task to create jquery-ui-themes-[VERSION].zip, to contain AUTHORS.txt, MANIFEST, MIT-LICENSE.txt, package.json and a folder with all the themes. Each folder has jquery-ui.css, jquery-ui.min.css, theme.css and an images folder. Should be exactly as the current themes quick download (on jqueryui.com).

For this, review the ​generation of the CDN zip file in the release script, since that duplicate some code needed for the above files.

Also improve error handling in that grunt task, specifically the ​check for existing files.

[Scott González]

This sounds good to me.

[rxaviers]

If the quick download should be consistent with a custom download, shall it include the "UI lightness + base theme" instead of "smoothness + base theme"?

[Scott González]

No, the theme should stay the same.

[rxaviers]

"The same" is the intriguing thing. Currently, stable download !== grunt build-packages !== custom download.

[Scott González]

Replying to rxaviers:

"The same" is the intriguing thing. Currently, stable download !== grunt build-packages !== custom download.

I'm not sure if you're referring to themes or structure here. All I was saying is that the theme should stay the same as it currently is. That is, the theme in the quick download should continue to be the theme that lives in git.

[rxaviers]

According to a recent IRC talk with Scott and Jörn, we agreed that the new stable download should be the same as a custom download using all defaults, except by not using ".custom" suffixes on file names.

[rxaviers]

Update build-packages task to output jquery-ui-[VERSION].zip (without the ".custom" postfix it currently has). Output is already consistent with a custom download, just wrapped in "development-bundle" folder, additional (concat/min) css and js folders and docs (instead of tests). Therefore no need to change the content.

Also extend the build-packages task to create jquery-ui-themes-[VERSION].zip, to contain AUTHORS.txt, MANIFEST, MIT-LICENSE.txt, package.json and a folder with all the themes. Each folder has jquery-ui.css, jquery-ui.min.css, theme.css and an images folder. Should be exactly as the current themes quick download (on jqueryui.com).

Implemented by ​https://github.com/jquery/download.jqueryui.com/commit/779b2dfca99c820aefff893d46c7988b38bdbce6

Also improve error handling in that grunt task, specifically the check for existing files.

Existing files do not abort the whole task anymore, instead it skips the existing ones...

For this, review the generation of the CDN zip file in the release script, since that duplicate some code needed for the above files.

Missing... Need to review and de-duplicate the code found on DB (grunt task above), and on jQuery UI build/release.js.

[Jörn Zaefferer]

The last missing piece was implemented here: ​https://github.com/jzaefferer/jquery-ui/commit/51d46a6105f5980e41b6d421d6c78f03289b4571 - part of this PR: ​https://github.com/jquery/jquery-ui/pull/1203

The changes are already done in the jqueryui.com repo, so I think this can be closed as fixed.

[Jörn Zaefferer]

Closing, see my previous comment for commit links.