Skip to main content

Search and Top Navigation

#9743 closed bug (fixed)

Opened January 17, 2014 05:41PM UTC

Closed April 28, 2014 10:20AM UTC

Release: Generate quick downloads

Reported by: scottgonzalez Owned by:
Priority: blocker Milestone: 1.11.0
Component: [meta] ui.build Version: 1.10.3
Keywords: Cc: rxaviers
Blocked by: Blocking:
Description

The code and theme zips need to be generated during release. The quick download that Download Builder generates right now doesn't seem to be linked from anywhere. That task should probably just generate the two zips we care about.

Attachments (0)
Change History (12)

Changed January 17, 2014 05:41PM UTC by scottgonzalez comment:1

milestone: none1.11.0
priority: minorblocker
status: newopen

Changed March 28, 2014 05:29PM UTC by jzaefferer comment:2

_comment0: Just discussed this with Rafael, our suggestion is as follows. If okay, Rafael can work on that. \ \ Update [https://github.com/jquery/download.jqueryui.com/blob/master/Gruntfile.js#L408 build-packages] task to output {{{jquery-ui-[VERSION].zip}}} (without the custom postfix it currently has). Output is already consistent with a custom download, just wrapped in "development-bundle" folder, additional (concat/min) css and js folders and docs (instead of tests). Therefore no need to change the content. \ \ Also extend the build-packages task to create {{{jquery-ui-themes-[VERSION].zip}}}, to contain AUTHORS.txt, MANIFEST, MIT-LICENSE.txt, package.json and a folder with all the themes. Each folder has jquery-ui.css, jquery-ui.min.css, theme.css and an images folder. Should be exactly as the current themes quick download (on jqueryui.com). \ \ For this, review the [https://github.com/jquery/jquery-ui/pull/1203/files#diff-0d42208d215c35b8397ef67c33d16c61R76 generation of the CDN zip file in the release script], since that duplicate some code needed for the above files. \ \ Also improve error handling in that grunt task, specifically the [https://github.com/jquery/download.jqueryui.com/blob/master/Gruntfile.js#L383 check for existing files]. \ 1396028006125581

Just discussed this with Rafael, our suggestion is as follows. If okay, Rafael can work on that.

Update build-packages task to output

jquery-ui-[VERSION].zip
(without the ".custom" postfix it currently has). Output is already consistent with a custom download, just wrapped in "development-bundle" folder, additional (concat/min) css and js folders and docs (instead of tests). Therefore no need to change the content.

Also extend the build-packages task to create

jquery-ui-themes-[VERSION].zip
, to contain AUTHORS.txt, MANIFEST, MIT-LICENSE.txt, package.json and a folder with all the themes. Each folder has jquery-ui.css, jquery-ui.min.css, theme.css and an images folder. Should be exactly as the current themes quick download (on jqueryui.com).

For this, review the generation of the CDN zip file in the release script, since that duplicate some code needed for the above files.

Also improve error handling in that grunt task, specifically the check for existing files.

Changed March 28, 2014 05:35PM UTC by jzaefferer comment:3

cc: → rxaviers

Changed March 31, 2014 02:52PM UTC by scottgonzalez comment:4

This sounds good to me.

Changed March 31, 2014 08:38PM UTC by rxaviers comment:5

If the quick download should be consistent with a custom download, shall it include the "UI lightness + base theme" instead of "smoothness + base theme"?

Changed March 31, 2014 09:00PM UTC by scottgonzalez comment:6

No, the theme should stay the same.

Changed March 31, 2014 09:05PM UTC by rxaviers comment:7

"The same" is the intriguing thing. Currently, stable download !== grunt build-packages !== custom download.

Changed April 01, 2014 01:40PM UTC by scottgonzalez comment:8

Replying to [comment:7 rxaviers]:

"The same" is the intriguing thing. Currently, stable download !== grunt build-packages !== custom download.

I'm not sure if you're referring to themes or structure here. All I was saying is that the theme should stay the same as it currently is. That is, the theme in the quick download should continue to be the theme that lives in git.

Changed April 01, 2014 03:21PM UTC by rxaviers comment:9

According to a recent IRC talk with Scott and Jörn, we agreed that the new stable download should be the same as a custom download using all defaults, except by not using ".custom" suffixes on file names.

Changed April 01, 2014 10:24PM UTC by rxaviers comment:10

Update build-packages task to output jquery-ui-[VERSION].zip (without the ".custom" postfix it currently has). Output is already consistent with a custom download, just wrapped in "development-bundle" folder, additional (concat/min) css and js folders and docs (instead of tests). Therefore no need to change the content.
Also extend the build-packages task to create jquery-ui-themes-[VERSION].zip, to contain AUTHORS.txt, MANIFEST, MIT-LICENSE.txt, package.json and a folder with all the themes. Each folder has jquery-ui.css, jquery-ui.min.css, theme.css and an images folder. Should be exactly as the current themes quick download (on jqueryui.com).

Implemented by https://github.com/jquery/download.jqueryui.com/commit/779b2dfca99c820aefff893d46c7988b38bdbce6

Also improve error handling in that grunt task, specifically the check for existing files.

Existing files do not abort the whole task anymore, instead it skips the existing ones...

For this, review the generation of the CDN zip file in the release script, since that duplicate some code needed for the above files.

Missing... Need to review and de-duplicate the code found on DB (grunt task above), and on jQuery UI build/release.js.

Changed April 09, 2014 04:41PM UTC by jzaefferer comment:11

The last missing piece was implemented here: https://github.com/jzaefferer/jquery-ui/commit/51d46a6105f5980e41b6d421d6c78f03289b4571 - part of this PR: https://github.com/jquery/jquery-ui/pull/1203

The changes are already done in the jqueryui.com repo, so I think this can be closed as fixed.

Changed April 28, 2014 10:20AM UTC by jzaefferer comment:12

resolution: → fixed
status: openclosed

Closing, see my previous comment for commit links.