#10602 closed bug (fixed)

Opened September 11, 2014 07:13AM UTC

Closed October 09, 2014 02:41PM UTC

Last modified October 15, 2014 12:08PM UTC

Tooltip: stays open by using click and TAB on inputs

Reported by: julien.pacchiarotti Owned by:
Priority: blocker Milestone: 1.11.2
Component: ui.tooltip Version: 1.11.1
Keywords: regression Cc:
Blocked by: Blocking:
Description

Hi,

I have just found an issue which I describe here => http://jsfiddle.net/L4k1byb8/

I have tested the same behavior in jquery ui 1.10.4 => http://jsfiddle.net/jwbx4a2g/ and it was working.

I have investigated a bit in the source code and my conclusion is this part of code could be the problem:

	close: function( event ) {
---
		this.closing = true;
		this._trigger( "close", event, { tooltip: tooltip } );

                //if you remove this if, it works
		if ( !this.hiding ) {
			this.closing = false;
		}
	},

	_tooltip: function( element ) {
---
Attachments (0)
Change History (8)

Changed September 11, 2014 07:19AM UTC by julien.pacchiarotti comment:1

Erratum: there is the correct jsfiddle with 1.10.4 => http://jsfiddle.net/jwbx4a2g/3/

I wanted to add that this seems to happen only when the tooltip is used with delegated items, otherwise it works => http://jsfiddle.net/2u7wvLp2/

Changed September 13, 2014 06:47PM UTC by tj.vantoll comment:2

keywords: → regression
status: new → open
summary: Tooltip stays open by using click and TAB on inputs → Tooltip: stays open by using click and TAB on inputs

This regressed in 1.11.1 because it worked fine in 1.11.0. There's only one related commit so it's almost certainly caused by https://github.com/jquery/jquery-ui/commit/32bef7ad4ea120fb32a79e1ea49bd9b846bcf835.

Changed September 15, 2014 09:35AM UTC by julien.pacchiarotti comment:3

Thanks for the correction, it works well ! If I am correct, this will be part of the next release of JQuery UI ?

Changed September 15, 2014 12:28PM UTC by tj.vantoll comment:4

Replying to [comment:3 julien.pacchiarotti]:

Thanks for the correction, it works well ! If I am correct, this will be part of the next release of JQuery UI ?

We don't know yet. We'll update this ticket when we do.

Changed September 17, 2014 04:22PM UTC by scottgonzalez comment:5

milestone: none → 1.11.2
priority: minor → blocker

Changed September 30, 2014 01:47PM UTC by scottgonzalez comment:6

PR: https://github.com/jquery/jquery-ui/pull/1353

Changed October 09, 2014 02:41PM UTC by Scott González comment:7

resolution: → fixed
status: open → closed

Tooltip: Properly track hiding and closing for delegated tooltips

Fixes #10602

Closes gh-1353

Changeset: 8825d93dc877d182cf4a3fce37b6c2593cf08552

Changed October 15, 2014 12:08PM UTC by scottgonzalez comment:8

#10659 is a duplicate of this ticket.