Skip to main content

Search and Top Navigation

#12770 closed feature (fixed)

Opened May 20, 2015 06:20PM UTC

Closed May 20, 2015 06:29PM UTC

Last modified July 01, 2015 03:44PM UTC

Remove dependency on core event alias module

Reported by: arschmitz Owned by: arschmitz
Priority: blocker Milestone: 1.12.0
Component: ui.core Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:
Description

There is no need for us to depend on the event alias module since it is just what it sounds like aliases. Not using aliases like focus and blur and click also improves code clarity because it will be clear when we are using a native call vs the jQuery event system.

Attachments (0)
Change History (3)

Changed May 20, 2015 06:23PM UTC by arschmitz comment:1

milestone: none1.12.0
owner: → arschmitz
priority: minorblocker
status: newassigned

Changed May 20, 2015 06:29PM UTC by Alexander Schmitz comment:2

resolution: → fixed
status: assignedclosed

Tests: Add custom build of core to tests

This adds a custom build which excludes the event/alias and deprecated modules

Fixes #12770

Closes gh-1556

Changeset: 6fd9fc92a372e222e3543f52979c601ac88ad81e

Changed July 01, 2015 03:44PM UTC by Jörn Zaefferer comment:3

Autocomplete: Revert mistaken event alias change

This is a call on the menu widget, not using an event alias.

Ref 8b4ce807cd97e3cb953995934d6c4f614de9fa03

Ref #12770

Changeset: de4984da244289c259e8fc8d1106898908b6ffce