Skip to main content

Search and Top Navigation

#13997 closed bug (fixed)

Opened August 10, 2015 02:42PM UTC

Closed August 14, 2015 02:45PM UTC

Widgets have inconsistent visual style

Reported by: arschmitz☃ Owned by:
Priority: minor Milestone: none
Component: ui.spinner Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:
Description

The visual style of the widgets is inconsistent in several places the main one being border color. Many of the widgets do not use the default border color on the outer widget and instead use the content border color ( slightly lighter ). This would seem to be semantically incorrect ( shouldn't all widgets use the default boder color by default? ) and is also inconsistent with what is done natively.

Spinners and buttons are a good example nativly a spinner and a button are the same height and have the same border color but the button widget uses the defautl border color while the spinner widget uses the content border color, the button widget is also much taller then the spinner widget. We should give all the widgets a consistent style.

http://jsbin.com/wabilu/edit?html,js,output

Side note: apparently the icons are missing on the cdn for the git build

Attachments (0)
Change History (2)

Changed August 14, 2015 02:44PM UTC by Alexander Schmitz comment:1

Theme: If make outer border consistent among widgets

Make sure all widgets use the default border color

Ref #13997

Ref #1586

Changeset: 559dc054621ca49cd513a8e8f13b2462e784cae8

Changed August 14, 2015 02:45PM UTC by Alexander Schmitz comment:2

resolution: → fixed
status: newclosed

Spinner: Add padding to input to give consistent visual style

Fixes #13997

Closes #1586

Changeset: caf6f2dc84295878f0a692b540e6f910b2a1d505