#4178 closed bug (fixed)

Opened February 18, 2009 05:28PM UTC

Closed February 16, 2012 09:52PM UTC

Last modified October 01, 2012 08:25PM UTC

Accordion animation a bit jumpy in some browsers

Reported by: scottgonzalez Owned by:
Priority: major Milestone: 1.9.0
Component: ui.accordion Version: 1.6rc6
Keywords: Cc:
Blocked by: Blocking:
Description

The animations are out of sync by a few pixels in some cases.

Attachments (0)
Change History (13)

Changed February 18, 2009 05:30PM UTC by scottgonzalez comment:1

summary: Accordion animatin a bit jumpy in some browsers → Accordion animation a bit jumpy in some browsers

Changed July 14, 2010 07:38PM UTC by scottgonzalez comment:2

milestone: 1.next → 1.9
priority: minor → major

Changed March 28, 2011 08:51PM UTC by scottgonzalez comment:3

status: new → open

Changed August 09, 2011 11:50AM UTC by scottgonzalez comment:4

#7617 is a duplicate of this ticket.

Changed August 25, 2011 12:48PM UTC by fiance comment:5

The error occurs in Chrome 13.0.782.112 m

Changed December 08, 2011 11:57AM UTC by speaktorob comment:6

This appears to be a case of not correctly calculating margins.

http://jsfiddle.net/speaktorob/mWeV2/4/

Changed December 08, 2011 01:21PM UTC by scottgonzalez comment:7

Replying to [comment:6 speaktorob]:

This appears to be a case of not correctly calculating margins.

No, it's a problem of trying to keep the sum of all values consistent while updating multiple properties. Removing the margins just reduces the number of places that the sum can be corrupted. You'll notice that bottom one does jump, just less.

Changed January 31, 2012 02:03PM UTC by scottgonzalez comment:8

Best attempt so far: https://github.com/jquery/jquery-ui/pull/587

Changed February 16, 2012 09:52PM UTC by Scott González comment:9

resolution: → fixed
status: open → closed

Accordion: Rewrote the animation code. Fixes #4178 - Accordion animation a bit jumpy in some browsers. Fixes #7371 - Accordion: Incorrect size when zoomed.

Changeset: 3d9f6b5bc74d09a08f6a116b6b31d93d72971f6d

Changed February 22, 2012 11:20PM UTC by ORIGINALUSRNM comment:10

_comment0: I'm confused as to why this is considered fixed. I have all the latest jQuery and jQuery UI code and the accordion is still jumpy. why is this considered fixed? → 1329953032079541
_comment1: So this fix is not yet in production, correct? → 1329953081392072

So this fix is not yet in production, correct? Shouldn't it still be considered open since

the most recent fix ( not yet in production) is still not steady cross-browser?

Changed February 23, 2012 12:00AM UTC by scottgonzalez comment:11

No. The ticket clearly states the milestone for the fix.

Changed May 25, 2012 11:45AM UTC by scottgonzalez comment:12

#8352 is a duplicate of this ticket.

Changed October 01, 2012 08:25PM UTC by Scott González comment:13

Accordion: New approach to synchronizing animations. Fixes #4178 - Accordion animation a bit jumpy in some browsers.

Changeset: d20f05ea37f17ec7799fb4d989c2ecba8689b096