Ticket #4178 (closed bug: fixed)
Accordion animation a bit jumpy in some browsers
| Reported by: | scott.gonzalez | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.9.0 |
| Component: | ui.accordion | Version: | 1.6rc6 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
The animations are out of sync by a few pixels in some cases.
Change History
comment:1 Changed 4 years ago by scott.gonzalez
- Summary changed from Accordion animatin a bit jumpy in some browsers to Accordion animation a bit jumpy in some browsers
comment:2 Changed 3 years ago by scott.gonzalez
- Priority changed from minor to major
- Milestone changed from 1.next to 1.9
comment:6 follow-up: ↓ 7 Changed 18 months ago by speaktorob
This appears to be a case of not correctly calculating margins.
comment:7 in reply to: ↑ 6 Changed 18 months ago by scott.gonzalez
Replying to speaktorob:
This appears to be a case of not correctly calculating margins.
No, it's a problem of trying to keep the sum of all values consistent while updating multiple properties. Removing the margins just reduces the number of places that the sum can be corrupted. You'll notice that bottom one does jump, just less.
comment:8 Changed 16 months ago by scott.gonzalez
Best attempt so far: https://github.com/jquery/jquery-ui/pull/587
comment:9 Changed 15 months ago by Scott González
- Status changed from open to closed
- Resolution set to fixed
Accordion: Rewrote the animation code. Fixes #4178 - Accordion animation a bit jumpy in some browsers. Fixes #7371 - Accordion: Incorrect size when zoomed.
Changeset: 3d9f6b5bc74d09a08f6a116b6b31d93d72971f6d
comment:10 Changed 15 months ago by ORIGINALUSRNM
So this fix is not yet in production, correct? Shouldn't it still be considered open since the most recent fix ( not yet in production) is still not steady cross-browser?
comment:11 Changed 15 months ago by scott.gonzalez
No. The ticket clearly states the milestone for the fix.
comment:12 Changed 12 months ago by scott.gonzalez
#8352 is a duplicate of this ticket.
comment:13 Changed 8 months ago by Scott González
Accordion: New approach to synchronizing animations. Fixes #4178 - Accordion animation a bit jumpy in some browsers.
Changeset: d20f05ea37f17ec7799fb4d989c2ecba8689b096