Ticket #4436 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Accordion fillSpace not accounting for header margins

Reported by: GreyCells Owned by:
Priority: major Milestone: 1.8
Component: ui.accordion Version: 1.7.1
Keywords: outerHeight margin Cc:
Blocking: Blocked by:

Description

This is similar to #4267, but just one specific problem with (in my use cases, at least) a very trivial solution.

If the accordion headers have a non-zero margin, fillSpace consistently calculates the incorrect height for the content div.

In r2307, changing line 182 from: maxHeight -= $(this).outerHeight(); to: maxHeight -= $(this).outerHeight(true); to account for the margins, appears to resolve this with no ill effects elsewhere.

Change History

comment:1 Changed 5 years ago by joern.zaefferer

  • Milestone changed from 1.7.2 to 1.8

comment:2 Changed 5 years ago by joern.zaefferer

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r3046.

Note: See TracTickets for help on using tickets.