Ticket #4621 (closed bug: fixed)

Opened 4 years ago

Last modified 14 months ago

Tabs: Don't forcefully remove filter attribute

Reported by: scott.gonzalez Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.tabs Version: 1.7.2
Keywords: Cc:
Blocking: Blocked by:

Description (last modified by scott.gonzalez) (diff)

As discussed on  jquery-ui-dev, we should deactivate the alpha filter instead of removing the filter attribute. Relies on  jQuery #6652.

Change History

comment:1 Changed 2 years ago by scott.gonzalez

  • Description modified (diff)

comment:2 Changed 15 months ago by joern.zaefferer

The underlying jQuery bug was fixed, but in master, _resetStyle still removes the filter attribute. Can we drop that now?

comment:3 Changed 15 months ago by scott.gonzalez

  • Status changed from new to open

No, because we still support jQuery 1.6.

comment:4 Changed 14 months ago by Scott González

  • Status changed from open to closed
  • Resolution set to fixed

Tabs: Don't explicitly remove filter when animating opacity. Fixes #4621 - Tabs: Don't forcefully remove filter attribute.

Changeset: c0f5db539403f1b9c5a80db75d127d4465f911df

comment:5 Changed 14 months ago by scott.gonzalez

I changed my mind. There's no reason for us to do any special handling in tabs when core has an officially supported solution. Anyone who needs the correct behavior using jQuery 1.6 - 1.6.2 can just redefine jQuery.cssHooks.opacity.set based on the current jQuery implementation.

Note: See TracTickets for help on using tickets.