Search and Top Navigation
#4621 closed bug (fixed)
Opened June 20, 2009 01:31PM UTC
Closed April 06, 2012 01:03PM UTC
Last modified April 06, 2012 01:04PM UTC
Tabs: Don't forcefully remove filter attribute
| Reported by: | scottgonzalez | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | ui.tabs | Version: | 1.7.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
As discussed on jquery-ui-dev, we should deactivate the alpha filter instead of removing the filter attribute. Relies on jQuery #6652.
Attachments (0)
Change History (5)
Changed May 16, 2011 03:53PM UTC by comment:1
| description: | As discussed on [http://groups.google.com/group/jquery-ui-dev/browse_thread/thread/4b99bd7ea3878902 jquery-ui-dev], we should deactivate the alpha filter instead of removing the filter attribute. Relies on [http://dev.jquery.com/ticket/4795 jQuery #4795]. → As discussed on [http://groups.google.com/group/jquery-ui-dev/browse_thread/thread/4b99bd7ea3878902 jquery-ui-dev], we should deactivate the alpha filter instead of removing the filter attribute. Relies on [http://dev.jquery.com/ticket/6652 jQuery #6652]. |
|---|
Changed February 27, 2012 03:38PM UTC by comment:2
The underlying jQuery bug was fixed, but in master, _resetStyle still removes the filter attribute. Can we drop that now?
Changed February 27, 2012 03:39PM UTC by comment:3
| status: | new → open |
|---|
No, because we still support jQuery 1.6.
Changed April 06, 2012 01:03PM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Tabs: Don't explicitly remove filter when animating opacity. Fixes #4621 - Tabs: Don't forcefully remove filter attribute.
Changeset: c0f5db539403f1b9c5a80db75d127d4465f911df
Changed April 06, 2012 01:04PM UTC by comment:5
I changed my mind. There's no reason for us to do any special handling in tabs when core has an officially supported solution. Anyone who needs the correct behavior using jQuery 1.6 - 1.6.2 can just redefine jQuery.cssHooks.opacity.set based on the current jQuery implementation.