Ticket #4623 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

CSS: ui-helper-hidden-accessible affects page layout

Reported by: kbwood Owned by:
Priority: minor Milestone: 1.8.7
Component: ui.css-framework Version: 1.7.2
Keywords: Cc:
Blocking: Blocked by:

Description

Ticket #4423 highlighted a problem with the ui-helper-hidden-accessible class and its application to the datepicker in pages with the body styled with direction: rtl. I can only reproduce this in IE7. The problem is the ui-helper-hidden-accessible class initially applied to the popup datepicker division. This positions it very far to the left, which effectively increases the page width and causes the location of the input field (jQuery.offset()) to be read as very far to the right. The datepicker is then shown at that position, i.e. off the screen. Thereafter the positioning undoes the initial setting and the datepicker shows normally. This needs to be fixed in the ThemeRoller core CSS. Rather than positioning to the left it could position above the page and not affect the horizontal rendering.

Change History

comment:1 Changed 5 years ago by joern.zaefferer

  • Milestone changed from TBD to 1.8

comment:2 Changed 5 years ago by scott.gonzalez

See also #4753.

comment:3 Changed 5 years ago by c_schmitz

I would love to get this fixed...

comment:4 Changed 4 years ago by kzamir

I can confirm this problem in ie7,8

As suggested above, changing:

.ui-helper-hidden-accessible { position: absolute; left: -99999999px; }

to:

.ui-helper-hidden-accessible { position: absolute; top: -99999999px; }

fixes this problem

comment:5 Changed 4 years ago by scott.gonzalez

  • Summary changed from ui-helper-hidden-accessible problems in right-to-left pages in IE7 to CSS: ui-helper-hidden-accessible affects page layout

comment:6 Changed 4 years ago by tombigel

A cleaner solution from html5boilerplate (tested, working on all browser):

position:absolute; clip: rect(0,0,0,0);

comment:7 Changed 4 years ago by Scott González

  • Status changed from new to closed
  • Resolution set to fixed

CSS: Rewrote .ui-helper-hidden-accessible base on HTML5 Boilerplate. Fixes #4623 - CSS: ui-helper-hidden-accessible affects page layout.

Changeset: a9d854967f0175b4c4b8a48c76a71d0fd1028680

comment:8 Changed 4 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.7

comment:9 Changed 4 years ago by geordie@…

For what it's worth the fix does not work on Chrome for Mac (but it works in Safari and Firefox on Mac). I had to add negatives for top and left to force Chrome not show scroll bars in one of my "overflow:auto;" divs that contained hidden items.

comment:10 Changed 4 years ago by scott.gonzalez

Works fine for me:  http://jsbin.com/uzaxo4/edit I don't get any scrollbars in Chrome.

Note: See TracTickets for help on using tickets.