Ticket #4645 (closed bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Accordion should only manipulate Icons that are children of ui-accordion-header

Reported by: ajpiano Owned by:
Priority: major Milestone: 1.8.3
Component: ui.accordion Version: 1.7.2
Keywords: Cc:
Blocking: Blocked by:

Description

Whether or not it is 100% wise to start having other icons in the accordion header, it should be possible to put icons up there without interference. Hence, this line in _clickHandler is too general: 

this.active.removeClass("ui-state-active ui-corner-top").addClass("ui-state-default ui-corner-all")

.find(".ui-icon").removeClass(o.icons.headerSelected).addClass(o.icons.header);

Change History

comment:1 Changed 4 years ago by scott.gonzalez

  • Milestone changed from 1.next to 1.8

comment:2 Changed 3 years ago by joern.zaefferer

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in  06f721b

comment:3 Changed 3 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.3

comment:4 Changed 3 years ago by jzaefferer

Use .children() instead of .find() to manipulate accordion icons. Fixes #4645 - Accordion should only manipulate Icons that are children of ui-accordion-header

Changeset: 06f721b74f94272baf5da96133e961f5600f5a90

Note: See TracTickets for help on using tickets.