Ticket #4681 (closed bug: fixed)

Opened 4 years ago

Last modified 2 years ago

Tabs: _sanitizeSelector needs to escape '.'

Reported by: liangent Owned by:
Priority: major Milestone: 1.9.0
Component: ui.tabs Version: 1.7.2
Keywords: Cc:
Blocking: Blocked by:

Description 

45	        _sanitizeSelector: function(hash) {
46	                return hash.replace(/:/g, '\\:'); // we need this because an id may contain a ":"
47	        },

return hash.replace(/:/g, '\\:'); should be changed into something like return hash.replace(/([:\.])/g, '\\$1');. because dots can also cause problems.

Change History

comment:1 Changed 4 years ago by joern.zaefferer

  • Milestone changed from TBD to 1.8

comment:2 Changed 2 years ago by scott.gonzalez

#6786 is a duplicate of this ticket.

comment:3 Changed 2 years ago by fofanafi

  • Status changed from new to open

Verified for jQuery UI 1.8.11. See duplicate bug for test case in jsFiddle and fix.

comment:4 Changed 2 years ago by tomgallacher

Fixed in Github:  https://github.com/jquery/jquery-ui/pull/244

comment:5 Changed 2 years ago by scott.gonzalez

  • Summary changed from _sanitizeSelector needs to escape '.' to Tabs: _sanitizeSelector needs to escape '.'

comment:6 Changed 2 years ago by Scott González

  • Status changed from open to closed
  • Resolution set to fixed

Tabs: Escape all special characters when sanitizing hash selectors. Fixes #4681 - Tabs: _sanitizeSelector needs to escape '.'.

Changeset: 5f10fa6511ae1965088926217776692a3f5663cb

Note: See TracTickets for help on using tickets.