Search and Top Navigation
#5100 closed feature (fixed)
Opened January 27, 2010 10:28AM UTC
Closed December 10, 2010 07:32PM UTC
Dialog: remove deprecated dialog option beforeclose
| Reported by: | rdworth | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9.0 |
| Component: | ui.dialog | Version: | 1.8b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The dialog option beforeclose was deprecated by #4669. It should be removed.
Attachments (0)
Change History (9)
Changed July 30, 2010 03:18PM UTC by comment:1
| milestone: | 1.next → 1.9 |
|---|---|
| priority: | minor → blocker |
Changed July 30, 2010 03:18PM UTC by comment:2
| type: | bug → feature |
|---|
Changed August 09, 2010 05:29PM UTC by comment:3
Im confused. So is beforeclose being deprecated altogether? Or is it correctly being renamed to beforeClose? If its only being renamed, I think an alias should exist for current sites using
Changed August 09, 2010 06:04PM UTC by comment:4
beforeclose is already deprecated, it has been renamed to beforeClose. There is an alias and that's what is going away.
Changed August 09, 2010 06:35PM UTC by comment:5
Docs should be updated to reflect this then since it is showing beforeclose as the method name
Changed August 09, 2010 07:36PM UTC by comment:6
Thanks for pointing that out. I've updated the docs.
Changed August 09, 2010 07:38PM UTC by comment:7
On this page: http://jqueryui.com/demos/dialog/#events ?
Changed August 09, 2010 07:51PM UTC by comment:8
The website docs at jqueryui.com/demos are updated at each point release based on what's at docs.jquery.com/UI which is where Scott did the update. So that fix will be live with 1.8.5