Ticket #5245 (closed bug: fixed)

Opened 3 years ago

Last modified 20 months ago

Relative width elements break when wrapped for effects.

Reported by: ajpiano Owned by: tomykaira
Priority: major Milestone: 1.9.0
Component: ui.effects.core Version: 1.8rc3
Keywords: slide effect Cc: gnarf
Blocking: Blocked by:

Description (last modified by gnarf) (diff)

As per this forum thread,  http://forum.jquery.com/topic/strange-slide-effectf-when-using-relative-width, the "slide" effect is jumpy on contained element.

 http://jsfiddle.net/n4vET/3/

Note that the jumpiness is manifested in Firefox, but not in Webkit.

The problem exists in createWrapper, the element is wrapped with a div, who's width is set to that of the element, at that point, the relative width recalculated, and thus the element "shrinks"

It also effects bounce & clip for sure, but potentially others as well.

Change History

comment:1 Changed 3 years ago by scott.gonzalez

  • Milestone changed from TBD to 1.next

comment:2 Changed 2 years ago by gnarf

comment:3 Changed 2 years ago by gnarf

  • Status changed from new to open

comment:4 Changed 2 years ago by tomykaira

 https://github.com/jquery/jquery-ui/pull/314

effects.slide: fix: reset width and height on the end of animation, get distance before wrapping. #5245-Slide Effect Broken With Relative Width

Tested with Firefox 4.

comment:5 Changed 2 years ago by gnarf

  • Cc gnarf added
  • Component changed from effects.* (individual effect) to effects.core
  • Description modified (diff)
  • Summary changed from Slide Effect Broken With Relative Width to Relative width elements break when wrapped for effects.

comment:6 Changed 2 years ago by tomykaira

 https://github.com/jquery/jquery-ui/pull/326

Effects.core: Storing size and setting in createWrapper for applied to all effects. Fixed #5245 - Relative width elements break when wrapped for effects.

This is discussed in  https://github.com/jquery/jquery-ui/pull/314 . Since this size problem is common among effects, I modified createWrapper and made it always store / set element size.

comment:7 Changed 2 years ago by gnarf

  • Owner set to tomykaira
  • Status changed from open to assigned

comment:8 Changed 2 years ago by tomykaira

  • Status changed from assigned to closed
  • Resolution set to fixed

effects.core: Convert elements height/width to px and restore after animation in all effects. Fixed #5245 - Relative width elements break when wrapped for effects

Changeset: 2c8151848d191ad9ba53c0ee86b14aefe4288f67

comment:9 Changed 2 years ago by gnarf

  • Milestone changed from 1.next to 1.9

comment:10 Changed 22 months ago by gnarf

#7611 is a duplicate of this ticket.

comment:11 Changed 20 months ago by gnarf

#7725 is a duplicate of this ticket.

Note: See TracTickets for help on using tickets.