Ticket #5321 (closed bug: fixed)

Opened 4 years ago

Last modified 2 years ago

Helper in a bottom-positioned Sortable is positioned wrong on drag start

Reported by: squeakytoy Owned by:
Priority: major Milestone: 1.8.21
Component: ui.sortable Version: 1.8rc3
Keywords: Cc:
Blocking: Blocked by:

Description

When a Sortable is placed in an absolutely positioned container where the position is set using 'bottom' with all other default settings, the helper is not positioned properly on drag start. It is positioned too high vertically by the amount of the height of the helper. The reason for this bug is that the placeholder has not yet been created at the time that the parent offset is calculated, and the bottom alignment of the list causes the offset to be calculated as a smaller amount.

The fix for this bug is to create the placeholder before the offsets are calculated. Attached is an html file that shows the big reproducible, and a patch to fix the issue.

Attachments

5321.patch Download (723 bytes) - added by squeakytoy 4 years ago.
Patch to resolve issue with helper positioning
sortable.html Download (917 bytes) - added by squeakytoy 4 years ago.
Repro of the issue

Change History

Changed 4 years ago by squeakytoy

Patch to resolve issue with helper positioning

Changed 4 years ago by squeakytoy

Repro of the issue

comment:1 Changed 4 years ago by squeakytoy

Ugh, ignore my late-night typos. At least the bug is fixed. :)

comment:2 Changed 4 years ago by scott.gonzalez

  • Milestone changed from TBD to 1.next

comment:4 Changed 2 years ago by martinf55

  • Status changed from new to closed
  • Resolution set to fixed

Sortable: Moved change of helper position css. Fixed #5321 – Helper in a bottom-positioned Sortable is positioned wrong on drag start.

Changeset: 32f356bbfa9a8f3b90b4e64331e9108b4d87a349

comment:5 Changed 2 years ago by martinf55

Sortable: Moved change of helper position css. Fixed #5321 – Helper in a bottom-positioned Sortable is positioned wrong on drag start. (cherry picked from commit 32f356bbfa9a8f3b90b4e64331e9108b4d87a349)

Changeset: 8e899dab6cd1fc410bbda0e7c88cdf1a1c8e9764

comment:6 Changed 2 years ago by scott.gonzalez

  • Milestone changed from 1.next to 1.8.21
Note: See TracTickets for help on using tickets.