Ticket #5545 (closed bug: fixed)

Opened 4 years ago

Last modified 2 years ago

Resizable: Callbacks ignore the grid

Reported by: nicholashall Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.resizable Version: 1.8
Keywords: haspatch Cc:
Blocking: Blocked by:

Description

If a resizable has a grid defined, the 'resize' callback continuously fires as though the box were resizing normally, one pixel at a time. The result is an erroneous and largely useless callback, essentially representing only user mouse movement.

Also from what I can tell the same logic is causing the ui.size.width argument that's passed to the 'stop' callback to be erroneous, having the value the box would have had if it were not constrained to a grid, instead of its true final width.

Change History

comment:1 Changed 2 years ago by eromba

Here is a test case:

 http://jsbin.com/owuqoc/#html

I've submitted a pull request with a fix and unit test here:

 https://github.com/jquery/jquery-ui/pull/694

comment:2 Changed 2 years ago by scott.gonzalez

  • Milestone changed from TBD to 2.0.0

comment:3 Changed 2 years ago by tj.vantoll

  • Keywords haspatch added
  • Status changed from new to open
  • Summary changed from Callbacks ignore the grid. to Resizable: Callbacks ignore the grid

comment:4 Changed 2 years ago by Ethan Romba

  • Status changed from open to closed
  • Resolution set to fixed

Resizable: Update CSS dimensions selectively. Fixes #7605 - Setting width and height when only one is changing

Resizable: Trigger resize event only when element is resized. Fixes #5545 - Callbacks ignore the grid.

Resizable: Added event tests. Fixes #5817 - resize event reports unconstrained ui.size

Changeset: 3974b55ba5078799df818c78d9273e11d9796ff3

comment:5 Changed 2 years ago by mikesherov

  • Milestone changed from 2.0.0 to 1.10.0
Note: See TracTickets for help on using tickets.