#5591 closed bug (fixed)

Opened May 07, 2010 11:06AM UTC

Closed May 11, 2010 12:37PM UTC

Last modified November 19, 2010 06:26PM UTC

Slider: can go outside min and max with keyboard

Reported by: koder Owned by:
Priority: minor Milestone: 1.8.2
Component: ui.slider Version: 1.8.1
Keywords: min value pagedown pgdown Cc: tim.koder@gmail.com
Blocked by: Blocking:
Description

When you create a slider with a min and max set. It will not slide under that min. That is correct.

However, when you use PageDown you *can* go under the min value! This is unwanted behaviour.

REPRODUCE:

1. Make a slide that prints out its current value

2. Move a slider up by a few steps

3. Press PageDown all the way

4. In some cases, it will go below its minimum value

EXAMPLE:

http://jqueryui.com/demos/slider/#rangemin

Attachments (0)
Change History (8)

Changed May 11, 2010 10:50AM UTC by watanabe comment:1

I think it's bug.

jQuery UI 1.8.1

jquery.ui.slider.js

line 186 (ui.slider _create this.handles.keydown)

case $.ui.keyCode.PAGE_DOWN:

PAGE_UP, UP, RIGHT, DOWN, LEFT have the same problem.

line 204 (the end of the switch block)

+ if (newVal != curVal) newVal = self._trimAlignValue(newVal);

may work.

Changed May 11, 2010 11:20AM UTC by rdworth comment:2

summary: Slider can go below its defined minimum → Slider: can go below its defined minimum with PageDown

Changed May 11, 2010 11:32AM UTC by rdworth comment:3

resolution: → fixed
status: new → closed

Fixed in b7c0823

Changed May 11, 2010 12:22PM UTC by watanabe comment:4

resolution: fixed
status: closed → reopened

Please forgive me for reopening this ticket.

Thanks for rdworth's patch.

"UP, RIGHT have the same problem." means,

.slider({
 min : 0,
 value : 90,
 max : 100,
 step : 15
});

90(curVal) + 15(step) = 105(newVal) > 100(valueMax).

Could I ask you to call _trimAlignValue() when adding/subtracting step?

Changed May 11, 2010 12:36PM UTC by rdworth comment:5

summary: Slider: can go below its defined minimum with PageDown → Slider: can go outside min and max with keyboard

Changed May 11, 2010 12:37PM UTC by rdworth comment:6

resolution: → fixed
status: reopened → closed

Thanks watanabe.

Further fixed in 114c001

Changed May 20, 2010 11:16AM UTC by rdworth comment:7

milestone: TBD → 1.8.2

Changed November 19, 2010 06:26PM UTC by jzaefferer comment:8

Autocomplete: Store term when selecting an item to prevent another search triggered before blur. Fixes #5591 - Home and End keys trigger search

Changeset: dea2f8a7fc1d7c1d8fbf69aa50d7c1f28c3f35b6