Ticket #5731 (closed bug: fixed)

Opened 4 years ago

Last modified 3 years ago

hide and show called with ommiting the options in parameters does not call the callback

Reported by: kobrigo Owned by:
Priority: major Milestone: 1.8.3
Component: ui.effects.core Version: 1.8.2
Keywords: Cc: kobrigo@…
Blocking: Blocked by:

Description

calling $(<some object selector>).hide('slide', 500, function(){

do somthing here });

will work but the callback will not execute.

on the function function _normalizeArguments(effect, options, speed, callback). which tries to do parmas shifting for function overloading.

Workaround could be to add an empty options object like this: some object selector>).hide('slide', {}, 500, function(){

do somthing here });

Attachments

uiBug.zip Download (54.9 KB) - added by kobrigo 4 years ago.
a test that demostrates the problem ( #div5 should call it's callback)

Change History

Changed 4 years ago by kobrigo

a test that demostrates the problem ( #div5 should call it's callback)

comment:1 Changed 4 years ago by kobrigo

calling $(<some object selector>).hide('slide', 500, function(){

do somthing here });

will work but the callback will not execute.

on the function function _normalizeArguments(effect, options, speed, callback). which tries to do parmas shifting for function overloading.

Workaround could be to add an empty options object like this: some object selector>).hide('slide', {}, 500, function(){

do somthing here });

Here is a link to my fix in github

 http://github.com/kobrigo/jquery-ui/commit/01dcb63cd3690a2aaf4d0c754b24ecac9c365d81

comment:2 Changed 4 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from TBD to 1.9

Fixed in  1417487. Thanks kobrigo.

comment:3 Changed 4 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.3

comment:4 Changed 3 years ago by kobrigo

Fixed argument shifting for effects. Fixes #5731 - hide and show called with ommiting the options in parameters does not call the callback.

Changeset: 141748788b034e97337ee7d9d137153c445097fd

Note: See TracTickets for help on using tickets.