Skip to main content

Search and Top Navigation

#5964 closed enhancement (fixed)

Opened August 17, 2010 02:15PM UTC

Closed August 27, 2010 05:21PM UTC

Last modified November 19, 2010 06:26PM UTC

Combine horizontalDefault and verticalDefault to one variable - possibly named center

Reported by: awirick Owned by:
Priority: minor Milestone: 1.8.5
Component: ui.position Version: 1.8.4
Keywords: center, horizontalDefault, verticalDefault Cc:
Blocked by: Blocking:
Description

Variables 'horizontalDefault' and 'verticalDefault' are both set initially to the string "center" and never modified. Consider combining these into a single variable.

old:

var horizontalPositions = /left|center|right/,
	horizontalDefault = "center",
	verticalPositions = /top|center|bottom/,
	verticalDefault = "center",
	_position = $.fn.position,
	_offset = $.fn.offset;

new:

var horizontalPositions = /left|center|right/,
	verticalPositions = /top|center|bottom/,
	center = "center",
	_position = $.fn.position,
	_offset = $.fn.offset;
Attachments (0)
Change History (3)

Changed August 27, 2010 05:21PM UTC by scottgonzalez comment:1

milestone: TBD1.9
resolution: → fixed
status: newclosed

Fixed in 2acfde9.

Changed September 10, 2010 05:27PM UTC by scottgonzalez comment:2

milestone: 1.91.8.5

Changed November 19, 2010 06:26PM UTC by Scott González comment:3

Position: Created center variable for better minification. Fixes #5964 - Combine horizontalDefault and verticalDefault to one variable - possibly named center.

Changeset: 2acfde9e5e411ece98bf7877212f0100d1c8c489