Search and Top Navigation
#5964 closed enhancement (fixed)
Opened August 17, 2010 02:15PM UTC
Closed August 27, 2010 05:21PM UTC
Last modified November 19, 2010 06:26PM UTC
Combine horizontalDefault and verticalDefault to one variable - possibly named center
Reported by: | awirick | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.8.5 |
Component: | ui.position | Version: | 1.8.4 |
Keywords: | center, horizontalDefault, verticalDefault | Cc: | |
Blocked by: | Blocking: |
Description
Variables 'horizontalDefault' and 'verticalDefault' are both set initially to the string "center" and never modified. Consider combining these into a single variable.
old:
var horizontalPositions = /left|center|right/, horizontalDefault = "center", verticalPositions = /top|center|bottom/, verticalDefault = "center", _position = $.fn.position, _offset = $.fn.offset;
new:
var horizontalPositions = /left|center|right/, verticalPositions = /top|center|bottom/, center = "center", _position = $.fn.position, _offset = $.fn.offset;
Fixed in 2acfde9.