Ticket #6012 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Dialog: _isOpen flag should be set before triggering open event

Reported by: dreamershl Owned by:
Priority: minor Milestone: 1.8.5
Component: ui.dialog Version: 1.8.4
Keywords: Cc:
Blocking: Blocked by:

Description

If you try to open the same dialog box in the open event, the code will re-invoke itself because the _isOpen is false. Is it better that switch the sequence of these 2 lines

from

self._trigger('open'); self._isOpen = true;

to

self._isOpen = true; self._trigger('open');

Change History

comment:1 Changed 3 years ago by scott.gonzalez

  • Summary changed from show dialog in the open event to Dialog: _isOpen flag should be set before triggering open event
  • Component changed from ui.core to ui.dialog
  • Milestone changed from TBD to 1.9

comment:2 Changed 3 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in  de02aa3.

comment:3 Changed 3 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.5

comment:4 Changed 3 years ago by Scott González

Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event.

Changeset: de02aa34a80eec32ad19e0c83ac88073ee551483

Note: See TracTickets for help on using tickets.