Ticket #6038 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Autocomplete: Allow default behaviour on enter when menu is open but inactive

Reported by: joern.zaefferer Owned by:
Priority: major Milestone: 1.8.6
Component: ui.autocomplete Version: 1.8.4
Keywords: Cc:
Blocking: Blocked by:

Description

To reproduce: Type something to open the autocomplete, then hit enter, without selecting something. The default behaviour, eg. submitting a search form should happen. Instead the default behaviour is prevented.

Change History

comment:1 Changed 4 years ago by bjoernhaeuser@…

Hello!

First i want to thank you for this great plugin. I really love it and its very comfortable to use. The only thing which bothers me is this enhancement (dont want to call it bug). Is there any fixe available?

Best regards!

comment:2 follow-up: ↓ 3 Changed 4 years ago by roncli

Confirmed a bug in version 1.8.5. I was previously using version 1.8.2 when it was last working correctly.

I worked around this by removing the following from jquery-ui-1.8.5.min.js:

case d.ENTER:case d.NUMPAD_ENTER:a.menu.element.is(":visible")&&c.preventDefault();

comment:3 in reply to: ↑ 2 Changed 4 years ago by scott.gonzalez

Replying to roncli:

Confirmed a bug in version 1.8.5. I was previously using version 1.8.2 when it was last working correctly.

Note that this is not a bug. The current behavior is intentional but we're planning on changing it.

comment:4 Changed 4 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in  adcafce.

comment:5 Changed 4 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.6

comment:6 Changed 4 years ago by Scott González

Autocomplete: Only prevent the default action for enter when a menu item is active. Fixes #6038 - Autocomplete: Allow default behaviour on enter when menu is open but inactive.

Thanks Ján Suchal.

Changeset: adcafce7a24156c503061eb354867e41064fd89f

Note: See TracTickets for help on using tickets.