Search and Top Navigation
#6067 closed bug (fixed)
Opened September 17, 2010 07:20PM UTC
Closed September 20, 2010 02:09PM UTC
Last modified November 19, 2010 06:26PM UTC
Dialog show/hide animations do not work
| Reported by: | chrisbarr | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.8.6 |
| Component: | ui.dialog | Version: | 1.8.5 |
| Keywords: | animation, show,animate,dialog | Cc: | |
| Blocked by: | Blocking: |
Description
Since the 1.8.5 update, when setting a custom animation to show or hide a dialog they do not take. It just uses the default .show(500) animation instead.
Here's the basic code I used. In 1.8.4 this would have animated properly.
$("myElement").dialog({
show:{
effect:"fade",
duration:500,
easing:"easeOutExpo"
},
hide:{
effect:"drop",
direction:"down",
distance:100,
duration:500,
easing:"easeOutExpo"
}
});
Attachments (0)
Change History (7)
Changed September 17, 2010 07:27PM UTC by comment:1
| resolution: | → worksforme |
|---|---|
| status: | new → closed |
Changed September 20, 2010 01:44PM UTC by comment:2
| resolution: | worksforme |
|---|---|
| status: | closed → reopened |
Replying to [comment:1 scott.gonzalez]:
Works for me: http://jsbin.com/eceta3
Scott, please take another look at your example. Yes it does ''animate'' but the animations are not correct - which is why I posted this ticket in the first place.
Go back and look and you'll see that the opening animation is a standard jQuery ''.show(500)'' and not a fade. The closing animation is a standard jQuery ''.hide(500)'' and not the drop effect.
Changed September 20, 2010 01:54PM UTC by comment:3
| milestone: | 1.next → 1.9 |
|---|
Sorry, I think I had actually done my testing with an earlier version and when I saw it was working bumped the version up, saw that it still animated (must not have paid attention to the actual animation) and thought it worked.
Changed September 20, 2010 02:09PM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | reopened → closed |
| summary: | Custom dialog show/hide animations do not work → Dialog show/hide animations do not work |
Fixed in ce08df3.
Changed September 20, 2010 07:22PM UTC by comment:5
Awesome, thanks so much. I patched my copy of jQuery UI with this fix and everything works great now.
Changed October 25, 2010 06:53PM UTC by comment:6
| milestone: | 1.9 → 1.8.6 |
|---|
Works for me: http://jsbin.com/eceta3