Search and Top Navigation
#6084 closed bug (fixed)
Opened September 20, 2010 06:50PM UTC
Closed September 20, 2010 06:57PM UTC
Last modified November 19, 2010 06:26PM UTC
Accordion: 1.8.5 not fully compatible with core 1.3.2
| Reported by: | jmiller | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.8.6 |
| Component: | ui.accordion | Version: | 1.8.5 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Current version of Accordion appears to be part of "Stable (1.8.5: jQuery 1.3.2+)", but line ~95 puts two classes into toggleClass like this: .toggleClass("ui-corner-all ui-corner-top"); which, on the 1.3.2 core, only results in classes being added, not removed. .toggleClass was substantially changed in 1.4.x and handles this just fine. The 1.7.x version had .toggleClass("ui-corner-all").toggleClass("ui-corner-top"); to be 1.3.x compatible instead.
The obvious solution is to mark 1.8.5 as 1.4.x compatible as opposed to tracking down and splitting out instances of .toggleClass.
Thanks for spotting this. We're not going to drop support for jQuery 1.3.2 until jQuery UI 1.9, so we'll just need to go back to the two calls.