Ticket #6084 (closed bug: fixed)
Accordion: 1.8.5 not fully compatible with core 1.3.2
| Reported by: | jmiller | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.8.6 |
| Component: | ui.accordion | Version: | 1.8.5 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
Current version of Accordion appears to be part of "Stable (1.8.5: jQuery 1.3.2+)", but line ~95 puts two classes into toggleClass like this: .toggleClass("ui-corner-all ui-corner-top"); which, on the 1.3.2 core, only results in classes being added, not removed. .toggleClass was substantially changed in 1.4.x and handles this just fine. The 1.7.x version had .toggleClass("ui-corner-all").toggleClass("ui-corner-top"); to be 1.3.x compatible instead.
The obvious solution is to mark 1.8.5 as 1.4.x compatible as opposed to tracking down and splitting out instances of .toggleClass.
Change History
comment:2 Changed 3 years ago by scott.gonzalez
- Status changed from new to closed
- Resolution set to fixed
Fixed in 9e19747.
comment:4 Changed 3 years ago by Scott González
Accordion: Don't pass multiple classes to .toggleClass(). Fixes #6084 - Accordion: 1.8.5 not fully compatible with core 1.3.2.
Changeset: 9e1974720931ee327d4c7c03ebb57e6e0fa9ecc7
Thanks for spotting this. We're not going to drop support for jQuery 1.3.2 until jQuery UI 1.9, so we'll just need to go back to the two calls.