Ticket #6634 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

minified css does not @include minified css files

Reported by: WanderingZombie Owned by:
Priority: minor Milestone: 1.8.7
Component: [meta] ui.build Version: 1.8.6
Keywords: Cc:
Blocking: Blocked by:

Description

themes/base/minified/jquery.ui.all.min.css

@import "jquery.ui.base.css";@import "jquery.ui.theme.css";

Clearly this is not what the user intended when referencing a minified file. It should be :

@import "jquery.ui.base.min.css";@import "jquery.ui.theme.min.css";

OR, as minified files are in a directory named minified, there's no real need to change the filename of each .css file.

Change History

comment:1 Changed 4 years ago by joern.zaefferer

  • Milestone changed from TBD to 1.9

Good catch. Missed that when adding minified CSS files.

comment:2 Changed 4 years ago by joern.zaefferer

  • Component changed from ui.core to [meta] ui.build

comment:3 Changed 4 years ago by joern.zaefferer

This does the trick, put into minify target:

		<replaceregexp match=".css" replace=".min.css" flags="g">
			<fileset dir="${dist.dir}/themes/base/minified/">
				<include name="*.base.min.css"/>
				<include name="*.all.min.css"/>
			</fileset>
		</replaceregexp>

comment:4 Changed 4 years ago by jzaefferer

  • Status changed from new to closed
  • Resolution set to fixed

Build: Replace filename references in base/all.min.css. Fixes #6634 - minified css does not @include minified css files.

Also make a copy of images to fix relative paths.

Changeset: 812c274a3376c4fee4d9705628a629d185bc86a9

comment:5 Changed 4 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.7
Note: See TracTickets for help on using tickets.