#6720 closed bug (fixed)

Opened December 05, 2010 04:43PM UTC

Closed January 11, 2011 06:21PM UTC

Last modified January 11, 2011 06:26PM UTC

Accordion: ol numbering bug

Reported by:	chyi1235	Owned by:
Priority:	minor	Milestone:	1.8.8
Component:	ui.accordion	Version:	1.8.6
Keywords:		Cc:
Blocked by:		Blocking:

Description

<ol> in the accordion content (under IE8 only) has been replaced. example can be seen here at http://www.ziweiuniversity.com/faq_bug.php

Trying clicking on first then second, back to first and second, and so on. Notice the li numbering system being replaced.

Looked like <li value=""> being updated by accordion.

Attachments (0)

Change History (9)

Changed December 05, 2010 07:38PM UTC by scottgonzalez comment:1

resolution:	→ worksforme
status:	new → closed

The numbers look fine to me. Tested in Safari, Firefox and Opera.

Changed December 05, 2010 08:32PM UTC by chyi1235 comment:2

as mentioned, not under IE 8

Changed December 05, 2010 08:33PM UTC by chyi1235 comment:3

sorry i mean as mentioned in my report, under IE 8

Changed December 05, 2010 09:52PM UTC by scottgonzalez comment:4

resolution:	worksforme
status:	closed → reopened

sorry, missed that part when the first time I read the ticket.

Changed December 06, 2010 02:02PM UTC by scottgonzalez comment:5

status:	reopened → open

Changed December 13, 2010 07:47PM UTC by hypnotoad comment:6

I have also encountered this issue within an FAQ section within a jQuery UI Accordion which has a similar structure to the following...

<ol>
  <li>
    <span class='faq_question'>Question...</span>
    <fieldset class='inactive' style='display:none'>
      <label>Answer<label>
      <span>The Answer...</span>
    </fieldset>
  </li>
  ....
  ....
</ol>

I also have the following jQuery script powering it...

$(".faq_question").click(function(){
  $(".faq_question").removeClass('selected').next().hide('slow');
  $(this).addClass('selected').next().show('slow');
});

My experience has been as follows.

1) Developed the web app, which was being imported into a corporate themed webpage via an iFrame for showing management the intended end result. No problem.

2) Moved the web application code into the body of the corporate themed webpage (removed the iFrame). The problem appeared.

The issue is only present in IE8, and does not appear when I tested with compatibility mode turned on. Furthermore, the issue always reverts the numbering of the <ol> to zero. However, I can manually click on the number and it will then display the correct number. I hope this helps.

Thanks

Changed December 14, 2010 01:17PM UTC by scottgonzalez comment:7

_comment0:	I've narrowed this down to [https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.accordion.js#L348-350 an .addClass() call in _clickHandler()]. Removing this line causes the numbering to work correctly. → 1292962800198745
summary:	ol numbering bug → Accordion: ol numbering bug

I've narrowed this down to an .addClass() call in _clickHandler(). Removing this line causes the numbering to work correctly.

Changed January 11, 2011 06:21PM UTC by Scott González comment:8

resolution:	→ fixed
status:	open → closed

Accordion: Start the accordion animation before changing classes. Fixes #6720 - Accordion: ol numbering bug.

Thanks Tony Ross.

Changeset: dd89ea5ff30a87d756453a73651cd30ae658492a

Changed January 11, 2011 06:26PM UTC by scottgonzalez comment:9

milestone:	1.9 → 1.8.8

Fixed in 1-8-stable in dd7aae2cc8789316592aaa5f191fa9bb546befa5.

Search and Top Navigation