Skip to main content

Search and Top Navigation

#6756 closed bug (fixed)

Opened December 16, 2010 07:58PM UTC

Closed January 31, 2013 02:22AM UTC

Last modified January 31, 2013 02:27AM UTC

Dialog: show: "blind" with link in content doesn't animate properly

Reported by: mjrjweb Owned by: mjrjweb
Priority: minor Milestone: 1.10.1
Component: ui.dialog Version: 1.8.4
Keywords: animation Cc:
Blocked by: Blocking:
Description

Blind effect on open (show) does not seem to go smoothly if there is a link in the dialog box. Previous version of jquery ui worked fine with link inside.

Did some testing and found that links in dialog work find with blind effect UNTIL jquery ui version 1.8.4.

I used latest version of jquery core.

Link[http://www.jensbits.com/demos/dialoglink.htm]

Attachments (0)
Change History (12)

Changed September 07, 2011 12:51PM UTC by scottgonzalez comment:1

keywords: → animation

Changed September 08, 2011 03:27PM UTC by scottgonzalez comment:2

status: newopen

Changed September 08, 2011 03:28PM UTC by scottgonzalez comment:3

summary: Link in dialog causes animation error with blind effect on openDialog: show: "blind" with link in content doesn't animate properly

Changed October 11, 2012 02:47PM UTC by scottgonzalez comment:4

milestone: 1.9.01.10.0

Changed October 23, 2012 12:21AM UTC by jzaefferer comment:5

This seems to work fine, not seeing any issue.

Changed October 23, 2012 01:30AM UTC by mikesherov comment:6

owner: → mjrjweb
status: openpending

In that case, I'll set this to pending on the off chance the OP has some repro steps. Mrjrweb, can you provide us more details?

Changed October 23, 2012 03:29PM UTC by jzaefferer comment:7

The demo uses "latest" versions from the CDN, so its very likely that this was an issue 14 months ago and got fixed by now.

Changed October 23, 2012 03:59PM UTC by scottgonzalez comment:8

status: pendingopen

Here's a proper test case: http://jsfiddle.net/mY9E2/ The animation is different because the dialog is shifted to make the focused anchor visible.

Changed October 23, 2012 04:01PM UTC by scottgonzalez comment:9

Chrome shows the animation as expected, all other browsers seem to have the same behavior.

Changed January 25, 2013 09:23PM UTC by tj.vantoll comment:10

milestone: 1.10.0none

Changed January 31, 2013 02:22AM UTC by Kris Borchers comment:11

resolution: → fixed
status: openclosed

Dialog: Move call to _focusTabbable and triggering of open and focus events into the _show callback. Fixes #6756 - Dialog: show: "blind" with link in content doesn't animate properly. Fixes #8051 - Dialog: 'Explode' dialog animation causes crash in IE 6, 7 and 8. Fixes #4421 - Dialog: Focus lost from dialog which uses show-effect

Changeset: d1505e3434ef99e0068347a5e8179a0ffd737676

Changed January 31, 2013 02:27AM UTC by scottgonzalez comment:12

milestone: none1.10.1