Ticket #6948 (closed bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Resizable autoHide Doesn't Work With Resizable's disable

Reported by: machineghost Owned by:
Priority: minor Milestone: 1.8.13
Component: ui.resizable Version: 1.8.9
Keywords: Cc:
Blocking: Blocked by:

Description

Ticket #3237 already has all the description of this issue, as well as code for a fix (in a comment I just added), but I don't have the power to re-open that issue, and I don't want this easily-fixable bug to get missed, so I'm filing this dupe. Hopefully someone with higher privileges can delete this bug as a dupe and instead re-open (or at the very least respond to) that one. Thanks!

Change History

comment:1 Changed 4 years ago by machineghost

Doh, and I filed it under the wrong component, sorry. Unfortunately I can't fix it because (even though I created this ticket) I don't have permissions to modify it. Sorry for the inconvenience; y'all really might want to consider slightly loosening edit permissions (at least on stuff people just filed two seconds ago) :-)

comment:2 Changed 4 years ago by scott.gonzalez

  • Status changed from new to open
  • Component changed from ui.core to ui.resizable

comment:3 Changed 4 years ago by machineghost

Scott suggested that I file a new bug for this, and since I already have, please do not close this as a dupe after all. However, please do refer to my comment on 3237 about both the issue and the fix. Also, please refer to my follow up comment which explains that I'm a moron who submitted a bad fix; the real fix shouldn't have .parent, so it should be a matter of changing ...

.hover(function() {
	$(this).removeClass("ui-resizable-autohide");
	self._handles.show();
},
function(){
	if (!self.resizing) {
		$(this).addClass("ui-resizable-autohide");
		self._handles.hide();
	}
});

to:

.hover(function() {
	if ($(this).is(".ui-resizable-disabled")) return;
	$(this).removeClass("ui-resizable-autohide");
	self._handles.show();
},
function(){
	if ($(this).is(".ui-resizable-disabled")) return;
	if (!self.resizing) {
		$(this).addClass("ui-resizable-autohide");
		self._handles.hide();
	}
});
Last edited 4 years ago by machineghost (previous) (diff)

comment:4 Changed 4 years ago by machineghost

P.S. Thanks Scott, sorry for the mess.

comment:5 Changed 3 years ago by carson

Last edited 3 years ago by carson (previous) (diff)

comment:6 Changed 3 years ago by Carson McDonald

  • Status changed from open to closed
  • Resolution set to fixed

Resizable: Skip autohide hover action when resizable is disabled. Fix #6948 - Resizable autoHide Doesn't Work With Resizable's disable (cherry picked from commit 0e2bc5efe217681c006ae7a16be21520e6563da6)

Changeset: 38af07ec4e916bc5fe1268b9878a21801368a78d

comment:7 Changed 3 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.13
Note: See TracTickets for help on using tickets.